Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Support anchorEl as a function #10420

Merged
merged 5 commits into from
Feb 23, 2018
Merged

[Popover] Support anchorEl as a function #10420

merged 5 commits into from
Feb 23, 2018

Conversation

quisido
Copy link
Contributor

@quisido quisido commented Feb 23, 2018

Added functional support for Popover (resolves #10411).
Fixed nested ternary operators.

Remaking this pull request, as my original PR was not done through Git (I wasn't expect such strict linting to shoot down a one-line change).
This pull request should be easier to maintain as I'm using a personal branch for any necessary revisions.

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 23, 2018
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anchorEl is used at different places in the component. Please abstract it into a function.

@oliviertassinari oliviertassinari self-assigned this Feb 23, 2018
@oliviertassinari oliviertassinari changed the title [Popover] Support anchorEl as a function. [Popover] Support anchorEl as a function Feb 23, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: Popover The React component. and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 23, 2018
@oliviertassinari oliviertassinari merged commit 4412572 into mui:v1-beta Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popover The React component. new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants