Cygwin: pipe: Fix a regression that raw_write() slows down #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the commit 7f3c225, writing to pipe extremely slows down. This is because cygwait(select_sem, 10, cw_cancel) is called even when write operation is already completed. With this patch, the cygwait() is called only if the write operation is not completed. Backported-from: 37ab3e0 (Cygwin: pipe: Fix a regression that raw_write() slows down, 2024-09-01) Addresses: https://cygwin.com/pipermail/cygwin/2024-August/256398.html Fixes: 7f3c225 ("Cygwin: pipe: handle signals explicitely in raw_write") Reported-by: Jim Reisert AD1C <jjreisert@alum.mit.edu> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
lgtm |
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Sep 4, 2024
This corresponds to msys2/msys2-runtime#227. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
lazka
pushed a commit
to msys2/MSYS2-packages
that referenced
this pull request
Sep 4, 2024
This corresponds to msys2/msys2-runtime#227. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported to the Cygwin mailing list that a
grepon a large file was much slower than it used to be. This is a backport of the fix.