Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Stylelint length-zero-no-unit rule #12846

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Enable the Stylelint length-zero-no-unit rule #12846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,8 @@

"rules": {
"block-no-empty": true,
"length-zero-no-unit": [true, {
ignore: ["custom-properties"]
}],
},
}
2 changes: 1 addition & 1 deletion test/annotation_layer_builder_overrides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
.annotationLayer .buttonWidgetAnnotation.pushButton > a {
opacity: 0.2;
background: rgba(255, 255, 0, 1);
box-shadow: 0px 2px 10px rgba(255, 255, 0, 1);
box-shadow: 0 2px 10px rgba(255, 255, 0, 1);
}

.annotationLayer .popupAnnotation,
Expand Down
4 changes: 2 additions & 2 deletions web/annotation_layer_builder.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
.annotationLayer .buttonWidgetAnnotation.pushButton > a:hover {
opacity: 0.2;
background: rgba(255, 255, 0, 1);
box-shadow: 0px 2px 10px rgba(255, 255, 0, 1);
box-shadow: 0 2px 10px rgba(255, 255, 0, 1);
}

.annotationLayer .textAnnotation img {
Expand Down Expand Up @@ -158,7 +158,7 @@
z-index: 200;
max-width: 20em;
background-color: rgba(255, 255, 153, 1);
box-shadow: 0px 2px 5px rgba(136, 136, 136, 1);
box-shadow: 0 2px 5px rgba(136, 136, 136, 1);
border-radius: 2px;
padding: 6px;
margin-left: 5px;
Expand Down
2 changes: 1 addition & 1 deletion web/pdf_viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}

.pdfViewer.removePageBorders .page {
margin: 0px auto 10px auto;
margin: 0 auto 10px auto;
border: none;
}

Expand Down
14 changes: 7 additions & 7 deletions web/text_layer_builder.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@
}

.textLayer .highlight.begin {
border-radius: 4px 0px 0px 4px;
border-radius: 4px 0 0 4px;
}

.textLayer .highlight.end {
border-radius: 0px 4px 4px 0px;
border-radius: 0 4px 4px 0;
}

.textLayer .highlight.middle {
border-radius: 0px;
border-radius: 0;
}

.textLayer .highlight.selected {
Expand All @@ -62,15 +62,15 @@
.textLayer .endOfContent {
display: block;
position: absolute;
left: 0px;
left: 0;
top: 100%;
right: 0px;
bottom: 0px;
right: 0;
bottom: 0;
z-index: -1;
cursor: default;
user-select: none;
}

.textLayer .endOfContent.active {
top: 0px;
top: 0;
}
16 changes: 8 additions & 8 deletions web/viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ select {
}

#viewerContainer.pdfPresentationMode:fullscreen {
top: 0px;
top: 0;
border-top: 2px solid rgba(0, 0, 0, 0);
background-color: rgba(0, 0, 0, 1);
width: 100%;
Expand Down Expand Up @@ -240,10 +240,10 @@ html[dir="rtl"] #sidebarContainer {
visibility: visible;
}
html[dir="ltr"] #outerContainer.sidebarOpen #sidebarContainer {
left: 0px;
left: 0;
}
html[dir="rtl"] #outerContainer.sidebarOpen #sidebarContainer {
right: 0px;
right: 0;
}

#mainContainer {
Expand Down Expand Up @@ -456,7 +456,7 @@ html[dir="rtl"] #outerContainer.sidebarOpen #loadingBar {
z-index: 10000;
height: auto;
min-width: 16px;
padding: 0px 4px 0px 4px;
padding: 0 4px 0 4px;
margin: 4px 2px 4px 2px;
color: rgba(217, 217, 217, 1);
font-size: 12px;
Expand Down Expand Up @@ -489,12 +489,12 @@ html[dir="rtl"] .findbar {
margin-top: 3px;
}
html[dir="ltr"] .findbar .splitToolbarButton {
margin-left: 0px;
margin-left: 0;
margin-right: 5px;
}
html[dir="rtl"] .findbar .splitToolbarButton {
margin-left: 5px;
margin-right: 0px;
margin-right: 0;
}

.findbar .splitToolbarButton > .toolbarButton {
Expand Down Expand Up @@ -1794,10 +1794,10 @@ html[dir="rtl"] #documentPropertiesOverlay .row > * {
}

html[dir="ltr"] #outerContainer.sidebarOpen #viewerContainer {
left: 0px !important;
left: 0 !important;
}
html[dir="rtl"] #outerContainer.sidebarOpen #viewerContainer {
right: 0px !important;
right: 0 !important;
}

#outerContainer .hiddenLargeView,
Expand Down