-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] JS -- Add default value in annotation data #12568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with these comments addressed.
b07ddcb
to
b0cb434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with this final commit addressed, and passing tests.
* these values are used when a form is resetted
b0cb434
to
39f5954
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bd4bc54068c4e23/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/59807e859d284b5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/bd4bc54068c4e23/output.txt Total script time: 24.97 mins
Image differences available at: http://54.67.70.0:8877/bd4bc54068c4e23/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/59807e859d284b5/output.txt Total script time: 28.84 mins
Image differences available at: http://3.101.106.178:8877/59807e859d284b5/reftest-analyzer.html#web=eq.log |
Thank you for improving this! |
These values are used when a form is reset.