Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] JS -- Add default value in annotation data #12568

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Nov 3, 2020

These values are used when a form is reset.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with these comments addressed.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with this final commit addressed, and passing tests.

 * these values are used when a form is resetted
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2020

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/bd4bc54068c4e23/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2020

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/59807e859d284b5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2020

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/bd4bc54068c4e23/output.txt

Total script time: 24.97 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/bd4bc54068c4e23/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2020

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/59807e859d284b5/output.txt

Total script time: 28.84 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/59807e859d284b5/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij changed the title JS -- Add default value in annotation data [api-minor] JS -- Add default value in annotation data Nov 5, 2020
@timvandermeij timvandermeij merged commit 646f895 into mozilla:master Nov 5, 2020
@timvandermeij
Copy link
Contributor

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants