Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
[skip ci]

Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
  • Loading branch information
badboy and Dexterp37 authored Jul 22, 2020
1 parent 8f670ce commit e9e7154
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ open class GleanInternalAPI internal constructor () {
Pass the correct state into `Glean.initialize()`.
See documentation at https://mozilla.github.io/glean/book/user/general-api.html#initializing-the-glean-sdk
""".trimIndent()
Log.w(LOG_TAG, msg)
Log.e(LOG_TAG, msg)
return
}
// Changing upload enabled always happens asynchronous.
Expand Down
2 changes: 1 addition & 1 deletion glean-core/csharp/Glean/Glean.cs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ public void SetUploadEnabled(bool enabled)
string msg = "Changing upload enabled before Glean is initialized is not supported.\n" +
"Pass the correct state into `Glean.initialize()`.\n" +
"See documentation at https://mozilla.github.io/glean/book/user/general-api.html#initializing-the-glean-sdk";
Log.Warning(msg);
Log.Error(msg);

return;
}
Expand Down
2 changes: 1 addition & 1 deletion glean-core/python/glean/glean.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ def set_upload_enabled(cls, enabled: bool) -> None:
See documentation at
https://mozilla.github.io/glean/book/user/general-api.html#initializing-the-glean-sdk
"""
log.warning(inspect.cleandoc(msg))
log.error(inspect.cleandoc(msg))
return

# Changing upload enabled always happens asynchronous.
Expand Down

0 comments on commit e9e7154

Please sign in to comment.