OBS-385: Replace django-pipeline #6864
Open
+1,103
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toufali
changed the title
toufali
commented
Jan 13, 2025
| @@ -16,10 +16,7 @@ | |||
| {% endblock %} | |||
| {% endblock %} | |||
|
|
|||
| {% block site_css %} | |||
| {% stylesheet 'crashstats_base' %} | |||
| {% stylesheet 'fontawesome' %} | |||
There was a problem hiding this comment.
I searched for the classes and fonts specified by the "fontawesome" stylesheet but couldn't find any used. This stylesheet is apparently only used on this page. This stylesheet may have originally been used for icons, but I notice other fonts being specified for icons, likely replacing the fontawesome package.
toufali
force-pushed
the
OBS-385/Replace-django-pipeline
branch
2 times, most recently
from
862b507 to
fb96602
Compare
- use crashstats_base as first test case - replace cssmin for minification - fix hacky filenames for fonts to work with ESBuild - remove unused "fontawesome" styles
toufali
force-pushed
the
OBS-385/Replace-django-pipeline
branch
from
fb96602 to
cc1fe63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a modern build tool such as ESBuild allows us to use best-practice CSS features such as
@importand advanced optimizations such as bundling, transpilation, and minification without the need for additional 3rd party tools and complex configuration.This is a work-in-progress posted for comment before applying changes to all other bundles/entrypoints (in bundles.py) :