fix: unmerged writeConcern options #2744
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 3.6.4 was added a depreciation warning about how writeConcern options should be formatted
node-mongodb-native/lib/write_concern.js
Lines 78 to 80 in d67ffa7
#2743 solves the problem of multiple emitions of depreciation warning, but digging into the code to find why this warning is triggered so many times, I found that
sourceOptions.writeConcern
is never merged intotargetOptions.writeConcern
inutils.mergeOptionsAndWriteConcern
node-mongodb-native/lib/utils.js
Lines 289 to 322 in d67ffa7
To fix it, my proposal is to add
writeConcern
to thecollectionKeys
in db.js. Also,utils.mergeOptionsAndWriteConcern
is not part of the public API and used only 1 time in db.js, so I propose to remove the trailing, alwaystrue
, argument :mergeWriteConcern
The original bug was reported here: https://jira.mongodb.org/browse/NODE-3114