Merge pull request #1584 from mongodb/port-pr-1559

[Port] Better error message for slash in hostname
mongodb · Nov 29, 2017 · f4c1b56 · f4c1b56
2 parents eb8b866 + 457bc29
commit f4c1b56
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/lib/url_parser.js b/lib/url_parser.js
@@ -198,7 +198,13 @@ function parseConnectionString(url, options) {
   for (i = 0; i < hosts.length; i++) {
     var r = parser.parse(f('mongodb://%s', hosts[i].trim()));
     if (r.path && r.path.indexOf(':') !== -1) {
-      throw new Error('Double colon in host identifier');
+      // Not connecting to a socket so check for an extra slash in the hostname.
+      // Using String#split as perf is better than match.
+      if (r.path.split('/').length > 1 && r.path.indexOf('::') === -1) {
+        throw new Error('Slash in host identifier');
+      } else {
+        throw new Error('Double colon in host identifier');
+      }
     }
   }
 

diff --git a/test/functional/url_parser_tests.js b/test/functional/url_parser_tests.js
@@ -990,4 +990,36 @@ describe('Url Parser', function() {
       });
     }
   });
+
+  /**
+   * @ignore
+   */
+  it('should raise exceptions on invalid hostnames with double colon in host identifier', {
+    metadata: {
+      requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
+    },
+    test: function(done) {
+      parse('mongodb://invalid::host:27017/db', {}, function(err) {
+        expect(err).to.exist;
+        expect(err.message).to.equal('Double colon in host identifier');
+        done();
+      });
+    }
+  });
+
+  /**
+   * @ignore
+   */
+  it('should raise exceptions on invalid hostnames with slash in host identifier', {
+    metadata: {
+      requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
+    },
+    test: function(done) {
+      parse('mongodb://invalid/host:27017/db', {}, function(err) {
+        expect(err).to.exist;
+        expect(err.message).to.equal('Slash in host identifier');
+        done();
+      });
+    }
+  });
 });