chore: replace strip-ansi with util.stripVTControlCharacters
#5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Indeed, still in triage. I want to wait and see if the other members of @mochajs/maintenance-crew have inputs. Marking this PR as a draft in the meantime. Thanks for sending! |
|
Nobody posted and this seems like a pretty straightforward dependency-to-builtin swap. I marked the issue as accepting PRs. Let's do this! 🚀 |
JoshuaKGoldberg
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
🚀 Great, glad it's such a straightforward swap-out!
I ran this locally and confirmed http://localhost:8080/#command-line-usage still has control characters stripped out.
JoshuaKGoldberg
changed the title
strip-ansi with util.stripVTControlCharactersstrip-ansi with util.stripVTControlCharacters
JoshuaKGoldberg
changed the title
strip-ansi with util.stripVTControlCharactersstrip-ansi with util.stripVTControlCharacters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
util.stripVTControlCharacters#5265status: accepting prsOverview
Replaced
strip-ansiwithutil.stripVTControlCharacters