mobx-react v6 #644

mweststrate · 2019-02-11T08:29:44Z

See #640

Uses the convention for HOC display names as outlined in the React documentation. Closes #466

… (if it needs to be brought back alive use error boundaries)

src/Provider.js

CHANGELOG.md

src/Provider.js

src/index.js

src/observer.js

mweststrate · 2019-02-14T10:22:42Z

Besides processing a lot of TODO's, the biggest open question atm is how to integrate with the DevTools.

package.json

CHANGELOG.md

Co-Authored-By: mweststrate <mweststrate@gmail.com>

CHANGELOG.md

… into SimeonC-hoc-conventions

…unsatisfied dependencies

mweststrate · 2019-03-21T13:55:15Z

mobx-react@6.0.0-rc.2 is now available!

samcooke98 · 2019-03-21T23:44:33Z

mobx-react@6.0.0-rc.2 is now available!

Just a heads-up, it seems that it breaks when attempting to use observer(someClassComponent)

https://codesandbox.io/s/j3k4p2jkv5

I did some digging, it seems h is the built <Observer> from mobx-react-lite - Not sure why it's not included in the bundle however?

danielkcz · 2019-03-22T07:37:50Z

The h is not the Observer, it should be React.createElement, but it's indeed missing in there for some reason. The Observer is minified under y and is there available.

@mweststrate I don't think you should be providing a minified code as a main, that should be a job for the consumer and that's probably a reason why external react is not referenced correctly.

mweststrate · 2019-03-22T09:28:07Z

Fixed in mobx-react@6.0.0-rc.4

…

On Fri, Mar 22, 2019 at 8:37 AM Daniel K. ***@***.***> wrote: The h is not the Observer, it should be React.createElement, but it's indeed missing in there for some reason. The Observer is minified under y and is there available. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#644 (comment)>, or mute the thread </~https://github.com/notifications/unsubscribe-auth/ABvGhLoom7uJ6zF9BiJjjbk0jojOwKb_ks5vZIhPgaJpZM4aztsd> .

xaviergonz · 2019-03-22T09:44:23Z

Are you using terser rather than uglify es? Terser fixed some react minification bugs

mweststrate · 2019-03-22T09:50:01Z

No, jsx wasn't configured for microbundle, causing it to default to `h` instead of `React.createElement`

…

On Fri, Mar 22, 2019 at 10:44 AM Javier Gonzalez ***@***.***> wrote: Are you using terser rather than uglify es? Terser fixed some react minification bugs — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#644 (comment)>, or mute the thread </~https://github.com/notifications/unsubscribe-auth/ABvGhN7CTAE8nN_GBc0Rrf-3rhx7fmYiks5vZKX5gaJpZM4aztsd> .

danielkcz · 2019-03-22T18:39:00Z

So I think you should remove reexport of useDisposable, useComputed and useObservable as I came to the conclusion these should be removed from lite package anyway. Let's not confuse people more by exposing these here.

danielkcz · 2019-05-12T18:45:06Z

src/index.js

-    }
-    __MOBX_DEVTOOLS_GLOBAL_HOOK__.injectMobxReact(mobxReact, mobx)
-}
+export { Provider } from "./Provider"


Note here we should probably export the Context object as well so people can make a custom hook for it. It's to support an easier migration instead of expecting from them to rewrite to new Context in a big swoop.

Suggested change

export { Provider } from "./Provider"

export { Provider, MobXProviderContext } from "./Provider"

macbem · 2019-05-15T09:10:12Z

README.md

+
+`mobx-react@6` and higher are no longer compatible with the mobx-react-devtools. 
+That is, the MobX react devtools will no longer show render timings or dependency trees of the component. 
+The reason is that the standard React devtools are no also capable of highlighting re-rendering components.


devtools are no also capable - what did you mean here? Looks like a typo.

@macbem Use the suggestions next time please

Suggested change

The reason is that the standard React devtools are no also capable of highlighting re-rendering components.

The reason is that the standard React devtools are also capable of highlighting re-rendering components.

Simeon Cheeseman and others added 7 commits May 7, 2018 10:55

fixes HOC displayName for observer and inject

998b2e6

Uses the convention for HOC display names as outlined in the React documentation. Closes #466

Started V6

6f8138c

Upgraded React to 16.8.0

b266442

Killed the observer overload that accepts store names` for auto inject

ac24719

Make sure reactions / components stof if a component throws exception…

61ae046

… (if it needs to be brought back alive use error boundaries)

Fixed broken inject test

886cb96

Implemented forwardRefs. Fixes #616 / #619

bf54f75

mweststrate mentioned this pull request Feb 11, 2019

TypeScript, MobX-React, and RefObjects #619

Closed

mweststrate added the breaking change label Feb 11, 2019

mweststrate added 10 commits February 11, 2019 11:45

Better links in changelog

825056c

Killed life-cycle compat

cd9977e

Basic implementation for modern context

5cd7b53

moved shallowEqual and is utilities

840a2f1

Provider: Forbid changing stores

a64c2d3

Some provider / inject cleanup

6957468

Removed duplicate context/inject tests

b015cd3

Fixed warning generated by inject

bc098c6

Provider can now redefine / combine stores

7e32fc0

Some random cleanup

3327e0f

danielkcz reviewed Feb 11, 2019

View reviewed changes

src/Provider.js Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

src/Provider.js Outdated Show resolved Hide resolved

mweststrate added 2 commits February 13, 2019 21:55

no longer supports property

c8212aa

WIP: use observer from mobx-react-lite for function components

2ea0f15

danielkcz reviewed Feb 14, 2019

View reviewed changes

src/index.js Outdated Show resolved Hide resolved

src/observer.js Show resolved Hide resolved

src/observer.js Outdated Show resolved Hide resolved

src/observer.js Outdated Show resolved Hide resolved

mweststrate added 2 commits February 14, 2019 11:15

Fixed most remaining tests

f68bf60

Use Observer from mobx-react-lite

0c77fd6

modernized rollup

e8e61b5

danielkcz reviewed Feb 14, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

mweststrate added 2 commits February 14, 2019 16:38

Blegh, filesize keeps failing

6807429

Jest update

f34dab3

mweststrate commented Feb 19, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestions from code review

2f6c76e

Co-Authored-By: mweststrate <mweststrate@gmail.com>

xaviergonz reviewed Feb 19, 2019

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

mweststrate added 3 commits March 10, 2019 22:38

Merge branch 'hoc-conventions' of /~https://github.com/SimeonC/mobx-react…

edc676b

… into SimeonC-hoc-conventions

Merge branch 'SimeonC-hoc-conventions' into v6

9554f64

Fixed changelog

96c9102

danielkcz mentioned this pull request Mar 10, 2019

Hooks can only be called inside the body of a function component. (https://fb.me/react-invalid-hook-call) #656

Closed

mweststrate added 3 commits March 21, 2019 14:06

Removed hoist-statics dependency

5116529

Fixed several typescript issues

464035b

Generate react-native build during compilation, so that there are no …

53f1dd2

…unsatisfied dependencies

danielkcz approved these changes Mar 21, 2019

View reviewed changes

mweststrate added 2 commits March 22, 2019 10:19

Disabled compressing since it seems to break React

6d23b11

Proper fix

24a5b35

danielkcz reviewed May 12, 2019

View reviewed changes

macbem reviewed May 15, 2019

View reviewed changes

mweststrate added 5 commits May 29, 2019 12:57

upgraded mobx-react-lite, processed some todo's

d152895

don't bundle mobx-react-lite, but depend on it

d0a3661

Added some tests for hooks

ce77e7e

Documentation improvements

516a21e

Some changelog / readme improvements

d5c832f

mweststrate merged commit d5c832f into master May 29, 2019

danielkcz deleted the v6 branch June 10, 2019 11:38

vkrol mentioned this pull request Aug 11, 2019

Do not minify bundles #759

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mobx-react v6 #644

mobx-react v6 #644

mweststrate commented Feb 11, 2019

mweststrate commented Feb 14, 2019

mweststrate commented Mar 21, 2019

samcooke98 commented Mar 21, 2019 •

edited

Loading

danielkcz commented Mar 22, 2019 •

edited

Loading

mweststrate commented Mar 22, 2019 via email

xaviergonz commented Mar 22, 2019

mweststrate commented Mar 22, 2019 via email

danielkcz commented Mar 22, 2019

danielkcz May 12, 2019 •

edited

Loading

macbem May 15, 2019

danielkcz May 15, 2019 •

edited

Loading

	export { Provider } from "./Provider"
	export { Provider, MobXProviderContext } from "./Provider"

	The reason is that the standard React devtools are no also capable of highlighting re-rendering components.
	The reason is that the standard React devtools are also capable of highlighting re-rendering components.

mobx-react v6 #644

mobx-react v6 #644

Conversation

mweststrate commented Feb 11, 2019

mweststrate commented Feb 14, 2019

mweststrate commented Mar 21, 2019

samcooke98 commented Mar 21, 2019 • edited Loading

danielkcz commented Mar 22, 2019 • edited Loading

mweststrate commented Mar 22, 2019 via email

xaviergonz commented Mar 22, 2019

mweststrate commented Mar 22, 2019 via email

danielkcz commented Mar 22, 2019

danielkcz May 12, 2019 • edited Loading

Choose a reason for hiding this comment

macbem May 15, 2019

Choose a reason for hiding this comment

danielkcz May 15, 2019 • edited Loading

Choose a reason for hiding this comment

samcooke98 commented Mar 21, 2019 •

edited

Loading

danielkcz commented Mar 22, 2019 •

edited

Loading

danielkcz May 12, 2019 •

edited

Loading

danielkcz May 15, 2019 •

edited

Loading