Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeanAgent Proofs #67

Merged
merged 3 commits into from
Nov 22, 2024
Merged

LeanAgent Proofs #67

merged 3 commits into from
Nov 22, 2024

Conversation

Adarsh321123
Copy link
Contributor

LeanAgent discovers proofs for theorems with the sorry keyword.

Copy link

google-cla bot commented Oct 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Owner

@mo271 mo271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!
Only the change in FormalBook/Chapter_08.lean is useful.

  • Proving wedderburn with Field.toIsField is not at all what the intention of the project is: we want to follow the proof provided in Proofs from the book. Of course Field.toIsField also uses a proof of wedderburn (which happens to follow somewhat closely the proof from the book, but we want to recreate it here, not just invoke it.)
  • Similarly "exact book.quadratic_reciprocity.quadratic_reciprocity_1 p q hp hq" is not useful, since we are planning to give a different proof here.

@mo271
Copy link
Owner

mo271 commented Oct 16, 2024

You write in the paper you reference above:
"In the Formal Book repository, LeanAgent progresses from proving basic real analysis
and number theory theorems to mastering advanced abstract algebra, exemplified by its proof of Wedderburn’s
Little Theorem"
I think you are really misunderstanding what is going on: It didn't master advanced abstract algebra, but rather there seems to be a misunderstanding of what the point of this repository is. The proof it "found" here in number theory are also trivial, there are two theorems quadratic_reciprocity_1 and quadratic_reciprocity_2 with the same statement where I the plan was to give two different proofs, of course quadratic_reciprocity_2 can be proved using quadratic_reciprocity_1.
The result in basic real analysis is a call to linarith, which works.

FormalBook/Chapter_05.lean Outdated Show resolved Hide resolved
@mo271 mo271 merged commit f2784bf into mo271:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants