Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixture - Slider and Chat #344

Merged
merged 42 commits into from
Feb 21, 2025
Merged

Fixture - Slider and Chat #344

merged 42 commits into from
Feb 21, 2025

Conversation

shincap8
Copy link
Contributor

Context

  • On click submit inside the chatrandom component would work due to how context was being handle, also the distinctive context wasn't so distinctive, and the slider and the radio button results weren't stored in the same place.

Changes Made

  1. Make distinctive context truly distinctive by filtering. by id none in example.
  • This would allow the users to truly see a context they haven't seen before
  1. Fix the handling of context inside the chatrandom component to be able so submit.
  • This would allow users to properly submit their results.
  1. Pass metadata to radio button component.
  • This would allow radio button and slider to be store in the same part as long as that parameter is equal (either false or true) for both components in yaml file
  1. Send Initial open to slider component.
  • This would allow challenge owners to set if they want this component to appeared open or closed from the beginning

shincap8 and others added 30 commits January 16, 2025 19:25
…t and creating score endpoint for runpod to use
Co-authored-by: Rafael Mosquera <rafael.mosquera@factored.ai>
@shincap8 shincap8 requested a review from a team as a code owner February 21, 2025 17:44
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@shincap8 shincap8 requested a review from remg1997 February 21, 2025 17:45
@shincap8 shincap8 merged commit 004229f into main Feb 21, 2025
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@shincap8 shincap8 deleted the Fixture/slider-and-chat branch February 21, 2025 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants