Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Eval meta #242

Merged
merged 8 commits into from
Feb 19, 2024
Merged

feat: Eval meta #242

merged 8 commits into from
Feb 19, 2024

Conversation

Ciroye
Copy link
Contributor

@Ciroye Ciroye commented Feb 13, 2024

No description provided.

Copy link

github-actions bot commented Feb 13, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@Ciroye Ciroye marked this pull request as ready for review February 19, 2024 01:37
@Ciroye Ciroye requested review from a team and remg1997 February 19, 2024 01:37
remg1997
remg1997 previously approved these changes Feb 19, 2024
Copy link
Collaborator

@remg1997 remg1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. I don't think any are required changes though.

<div className="p-4 bg-white">
<h2 className="mb-4 text-2xl font-bold">Instructions</h2>
<p className="text-gray-600">
You are playing the part of a 47-year-old female patient who is
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you want to keep this placeholder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be replaced in the next PR

const { user } = useContext(UserContext);

const checkIfUserIsSignedInConsent = async () => {
const signConsent = await post("/task/check_sign_consent", {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the endpoint we're calling to check_signed_consent. Not urgent, but definitely an improvement.

@Ciroye Ciroye merged commit 9c4392e into main Feb 19, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants