Refactor tag value retrieval logic in SchemingDCATRDFProfile to improve handling of empty labels and streamline return values #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve handling of empty labels and streamline return values
mjanez
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
_search_value_codelistmethod in theckanext/schemingdcat/profiles/base.pyfile to improve readability and logic flow. The most important changes include restructuring the dictionary creation and conditional checks.Improvements to readability and logic flow:
ckanext/schemingdcat/profiles/base.py: Moved the check for an emptylabelto the beginning of the method, ensuring early return iflabelis not provided.ckanext/schemingdcat/profiles/base.py: Simplified the conditional logic by removing redundant checks and combining return statements.ckanext/schemingdcat/profiles/base.py: Reformatted the dictionary comprehension for better readability.