Fix disabled buttons

mj12albert · Feb 28, 2025 · 4f8160d · 4f8160d
1 parent e45f308
commit 4f8160d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/react/src/number-field/decrement/NumberFieldDecrement.tsx b/packages/react/src/number-field/decrement/NumberFieldDecrement.tsx
@@ -17,7 +17,7 @@ const NumberFieldDecrement = React.forwardRef(function NumberFieldDecrement(
   props: NumberFieldDecrement.Props,
   forwardedRef: React.ForwardedRef<HTMLButtonElement>,
 ) {
-  const { render, className, ...otherProps } = props;
+  const { render, className, disabled: disabledProp = false, ...otherProps } = props;
 
   const {
     allowInputSyncRef,
@@ -50,7 +50,7 @@ const NumberFieldDecrement = React.forwardRef(function NumberFieldDecrement(
     maxWithDefault,
     value,
     inputValue,
-    disabled,
+    disabled: disabledProp || disabled,
     readOnly,
     id,
     setValue,
@@ -102,6 +102,10 @@ NumberFieldDecrement.propTypes /* remove-proptypes */ = {
    * returns a class based on the component’s state.
    */
   className: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
+  /**
+   * @ignore
+   */
+  disabled: PropTypes.bool,
   /**
    * Allows you to replace the component’s HTML element
    * with a different tag, or compose it with another component.

diff --git a/packages/react/src/number-field/increment/NumberFieldIncrement.tsx b/packages/react/src/number-field/increment/NumberFieldIncrement.tsx
@@ -17,7 +17,7 @@ const NumberFieldIncrement = React.forwardRef(function NumberFieldIncrement(
   props: NumberFieldIncrement.Props,
   forwardedRef: React.ForwardedRef<HTMLButtonElement>,
 ) {
-  const { render, className, ...otherProps } = props;
+  const { render, className, disabled: disabledProp = false, ...otherProps } = props;
 
   const {
     state,
@@ -50,7 +50,7 @@ const NumberFieldIncrement = React.forwardRef(function NumberFieldIncrement(
     maxWithDefault,
     value,
     inputValue,
-    disabled,
+    disabled: disabledProp || disabled,
     readOnly,
     id,
     setValue,
@@ -102,6 +102,10 @@ NumberFieldIncrement.propTypes /* remove-proptypes */ = {
    * returns a class based on the component’s state.
    */
   className: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
+  /**
+   * @ignore
+   */
+  disabled: PropTypes.bool,
   /**
    * Allows you to replace the component’s HTML element
    * with a different tag, or compose it with another component.