(fix) Hotcue sort: collect only cues with valid hotcue index

[ronso0]

Fixup for #13808

Also check for valid hotcue index when collecting hotcues.
These create issues:

• Loop and index -1 is the temporary loop
• and there may be orphaned Hotcues with invalid index

---

I noticed that sorting hotcues would magically create new hotcues and loopcues, some even at the same pos / close to existing (valid) hotcues. Checking the database, I have about 3000 of such cues.
Seems they have accumulated over the past ~10 years 🤷

[ronso0]

We may also add a cleanup function, to be called for example when reading track cues?

[Swiftb0y]

Thank you.

[ronso0]

I added the same check when setting the new indices 🙄

[ronso0]

We may also add a cleanup function, to be called for example when reading track cues?

Wdyt?
Or should this rather be part of /~https://github.com/mixxxdj/mixxx/blob/main/tools/mixxxdb_cleanup.sql, or a separate script?

[Swiftb0y]

If you're talking about cleaning up the orphaned hotcues, then it should be part of the cleanup script IMO.

[ronso0]

My thought was that regular users are not aware of the script.
I'll file an issue.

edit #14424