Invoke xdpbpfexport.exe from MSI install/uninstall #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR has conflicts too. |
yeah, this PR has been shelved for weeks. converting to draft. |
mtfriesen
changed the title
nibanks
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XDP isn't registering its eBPF characteristics within the MSI installer, which causes certain eBPF features to break. Somewhat surprisingly, the libbpf APIs covered by the functional tests work fine.
Add an optional feature to our MSI installer and runtime installer script.
This was missed in #443. Also add an automated test to catch the scenario.
Resolves #567