Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search in Cell Selection to Notebook Find Widget #213409

Merged
merged 3 commits into from
May 28, 2024

Conversation

Yoyokrazy
Copy link
Contributor

@Yoyokrazy Yoyokrazy commented May 24, 2024

Re: #209839

Doesn't fully close out the issue, as there still needs to be a tweak to the selection toggle. Should work inside a cell to do selection searches (mimic the basic editor feature)

@Yoyokrazy Yoyokrazy requested a review from rebornix May 24, 2024 18:06
@Yoyokrazy Yoyokrazy self-assigned this May 24, 2024
@vscodenpa vscodenpa added this to the May 2024 milestone May 24, 2024
@Yoyokrazy
Copy link
Contributor Author

Yoyokrazy commented May 24, 2024

Todo:

  • add cell decoration to make sure it's obvious what the selection scope is, as the users navigate across their matches.

Another PR:

  • Shift webview filtering to happen pre search. ie use the cell Ids to only search through the necessary portions of the webview, and also warm up selectively.
  • Make search in cell selection button also apply to editor selection. Should effectively be able to mimic standard editor search while inside a code or md cell in editing mode

@Yoyokrazy Yoyokrazy requested a review from rebornix May 24, 2024 23:26
@Yoyokrazy Yoyokrazy merged commit 49eedd7 into main May 28, 2024
6 checks passed
@Yoyokrazy Yoyokrazy deleted the milively/nb-find-selection branch May 28, 2024 05:25
@microsoft microsoft locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants