Fixes #169854: ignore surprising dom nodes

microsoft · Aug 23, 2023 · 8fe686f · 8fe686f
1 parent 2ab4a3f
commit 8fe686f
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/vs/editor/browser/controller/mouseTarget.ts b/src/vs/editor/browser/controller/mouseTarget.ts
@@ -198,6 +198,13 @@ class ElementPath {
 		);
 	}
 
+	public static isChildOfOverflowGuard(path: Uint8Array): boolean {
+		return (
+			path.length >= 1
+			&& path[0] === PartFingerprint.OverflowGuard
+		);
+	}
+
 	public static isChildOfOverflowingContentWidgets(path: Uint8Array): boolean {
 		return (
 			path.length >= 1
@@ -538,6 +545,11 @@ export class MouseTargetFactory {
 
 		let result: IMouseTarget | null = null;
 
+		if (!ElementPath.isChildOfOverflowGuard(request.targetPath) && !ElementPath.isChildOfOverflowingContentWidgets(request.targetPath)) {
+			// We only render dom nodes inside the overflow guard or in the overflowing content widgets
+			result = result || request.fulfillUnknown();
+		}
+
 		result = result || MouseTargetFactory._hitTestContentWidget(ctx, resolvedRequest);
 		result = result || MouseTargetFactory._hitTestOverlayWidget(ctx, resolvedRequest);
 		result = result || MouseTargetFactory._hitTestMinimap(ctx, resolvedRequest);