Fix GitHub issue 1036: debug command variables throw exception #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/microsoft/vscode-cmake-tools into dev/andris/cmake_tools/github_issue_1036
bobbrow
approved these changes
Feb 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1036
This is a regression from the multi root feature shipped with 1.3 beta.
The various debug/launch commands expect now an argument of type WorkspaceFolder or a string, which represents the active folder of the json that is invoking them.
In the json of the repro there is no such argument defined and VSCode is automatically passing the whole debug configuration to the launch commands. The type mismatch is causing various issues, including the exception "cannot read property ... of undefined".
This change is fixing the single root case and addresses a few multi root scenarios. More fixes for the whole debug/launch commands experience with multi root will follow, including new ways of defining the workspace folder argument in launch.json.