azure: use management endpoint in createGenericClient
#1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
approved these changes
Jan 26, 2024
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
managementEndpointUrlinstead ofresourceManagerEndpointUrlincreateGenericClient.Fixes an issue that surfaces with the changes in #1669 with sovereign clouds. I'll explain more below.
createGenericClientis used to make calls against the kudu service, which were failing with 403 errors because the access token audience was incorrectly set to the resource manager endpoint and not the management endpoint. Sovereign clouds must be more sensitive about which audience is used because it works fine for normal Azure.We still use
resourceManagerEndpointUrltwo other times in this file, forcreateAzureSubscriptionClientandcreateAzureClient. I'm going to leave these as-is for now because as far as I know, only kudu calls were breaking.