auth: Make getSession synchronous
#1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm (after multiple tries) this does in fact fix. |
bwateratmsft
previously approved these changes
Nov 3, 2023
Don't Starve intensifies |
alexweininger
previously approved these changes
Nov 3, 2023
There was a problem hiding this comment.
awkward
But also yeah we shouldn't need cross-fetch or node-fetch now that we can use the build-in fetch. I did that in #1614, so just copy over those changes to here.
nturinski
dismissed stale reviews from alexweininger and bwateratmsft
via
48cff30
bwateratmsft
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually fixes: microsoft/vscode-azurefunctions#3878
This PR broke everything. 😡
Apparently
AzureAuthenticationdoesn't likegetSessionbeing async. So we need to be able to get the session and pass that along before we create the authentication object.The async call must have somehow caused some parts of the zipfile not to get deployed since the stream was constantly making requests. Not sure why it only reproduces on Windows either. I'm assuming the auth provider was fast enough on a Mac to never actually be an issue.
Anyway, I'm making scopes an optional parameter on
createSubscriptionClient. I think that should resolve the problem of not being able to pass scopes.Also could someone double check to make sure that I reverted everything? I think that this is all, but my sanity bar is nearly depleted atm.