PR feedback

microsoft · Jul 21, 2022 · c2faa45 · c2faa45
1 parent 87458e4
commit c2faa45
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 13 deletions.
diff --git a/appservice/src/createAppService/AppInsightsCreateStep.ts b/appservice/src/createAppService/AppInsightsCreateStep.ts
@@ -40,8 +40,15 @@ export class AppInsightsCreateStep extends AzureWizardExecuteStep<IAppServiceWiz
                     ext.outputChannel.appendLog(creatingNewAppInsights);
                     progress.report({ message: creatingNewAppInsights });
 
-                    context.appInsightsComponent = await client.components.createOrUpdate(rgName, aiName, { kind: 'web', applicationType: 'web', location: appInsightsLocation, 
-                    workspaceResourceId: context.logAnalyticsWorkspace?.id});
+                    context.appInsightsComponent = await client.components.createOrUpdate(
+                        rgName,
+                        aiName,
+                        {
+                            kind: 'web',
+                            applicationType: 'web',
+                            location: appInsightsLocation,
+                            workspaceResourceId: context.logAnalyticsWorkspace?.id
+                        });
                     const createdNewAppInsights: string = localize('createdNewAppInsights', 'Successfully created Application Insights resource "{0}".', aiName);
                     ext.outputChannel.appendLog(createdNewAppInsights);
                 } else if (pError.errorType === 'AuthorizationFailed') {

diff --git a/appservice/src/createAppService/IAppServiceWizardContext.ts b/appservice/src/createAppService/IAppServiceWizardContext.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { ApplicationInsightsComponent } from '@azure/arm-appinsights';
+import type { ApplicationInsightsComponent } from '@azure/arm-appinsights';
 import type { AppServicePlan, Site, SkuDescription } from '@azure/arm-appservice';
 import type { Workspace } from '@azure/arm-operationalinsights';
 import { IResourceGroupWizardContext, IStorageAccountWizardContext } from '@microsoft/vscode-azext-azureutils';
@@ -95,7 +95,7 @@ export interface IAppServiceWizardContext extends IResourceGroupWizardContext, I
      * it will look for a workspace within the same resource group and location as the App Insight
      * component. If neither conditions are met, then it will automatically create a workspace
      */
-     logAnalyticsWorkspace?: Workspace;
+    logAnalyticsWorkspace?: Workspace;
 
     /**
      * Indicates advanced creation should be used

diff --git a/appservice/src/createAppService/getAppInsightsSupportedLocation.ts b/appservice/src/createAppService/getAppInsightsSupportedLocation.ts
@@ -3,11 +3,10 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import type { Provider } from '@azure/arm-resources';
-import { ResourceManagementClient, ProviderResourceType } from "@azure/arm-resources";
-import { ServiceClient, HttpOperationResponse } from "@azure/ms-rest-js";
+import type { Provider, ProviderResourceType, ResourceManagementClient } from '@azure/arm-resources';
+import type { HttpOperationResponse, ServiceClient } from "@azure/ms-rest-js";
 import { AzExtLocation, createGenericClient } from "@microsoft/vscode-azext-azureutils";
-import { nonNullProp, IActionContext } from "@microsoft/vscode-azext-utils";
+import { IActionContext, nonNullProp } from "@microsoft/vscode-azext-utils";
 import { createResourceClient } from "../utils/azureClients";
 import { areLocationNamesEqual } from "../utils/azureUtils";
 import { IAppServiceWizardContext } from "./IAppServiceWizardContext";
@@ -64,12 +63,12 @@ async function getLocations(context: IAppServiceWizardContext): Promise<string[]
 }
 
 type RegionMappingJsonResponse = {
-regions: {
-    [key: string]: RegionMap
-}
+    regions: {
+        [key: string]: RegionMap
+    }
 };
 
 type RegionMap = {
-geo: string,
-pairedRegions: string[]
+    geo: string,
+    pairedRegions: string[]
 };