Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all .NET 5 tests since its EOL #3832

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Remove all .NET 5 tests since its EOL #3832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/createFunction/createFunction.CSharp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ class CSharpFunctionTester extends FunctionTesterBase {
for (const source of allTemplateSources) {
addSuite(FuncVersion.v2, 'netcoreapp2.1', source);
addSuite(FuncVersion.v3, 'netcoreapp3.1', source);
addSuite(FuncVersion.v3, 'net5.0', source, true);
addSuite(FuncVersion.v4, 'net5.0', source, true);
addSuite(FuncVersion.v4, 'net6.0', source, true);
addSuite(FuncVersion.v4, 'net6.0', source, false);
addSuite(FuncVersion.v4, 'net7.0', source, true);
Expand Down
18 changes: 1 addition & 17 deletions test/createFunction/createFunction.JavaScript.v1.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
*--------------------------------------------------------------------------------------------*/

import * as path from 'path';
import * as vscode from 'vscode';
import { FuncVersion, funcVersionSetting, ProjectLanguage, projectLanguageSetting, TemplateSource } from '../../extension.bundle';
import { FuncVersion, ProjectLanguage, TemplateSource } from '../../extension.bundle';
import { allTemplateSources, shouldSkipVersion } from '../global.test';
import { runWithFuncSetting } from '../runWithSetting';
import { FunctionTesterBase } from './FunctionTesterBase';

class JSFunctionTesterV1 extends FunctionTesterBase {
Expand Down Expand Up @@ -98,19 +96,5 @@ for (const source of allTemplateSources) {
'0 * 0/5 * * *'
);
});

// /~https://github.com/Microsoft/vscode-azurefunctions/blob/main/docs/api.md#create-local-function
test('createFunction API (deprecated)', async () => {
const templateId: string = 'HttpTrigger-JavaScript';
const functionName: string = 'createFunctionApi';
const authLevel: string = 'Anonymous';
// Intentionally testing weird casing for authLevel
await runWithFuncSetting(projectLanguageSetting, ProjectLanguage.JavaScript, async () => {
await runWithFuncSetting(funcVersionSetting, FuncVersion.v1, async () => {
await vscode.commands.executeCommand('azureFunctions.createFunction', jsTester.projectPath, templateId, functionName, { aUtHLevel: authLevel });
});
});
await jsTester.validateFunction(jsTester.projectPath, functionName, [authLevel]);
});
});
}
1 change: 0 additions & 1 deletion test/nightly/createProjectAndDeploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const testCases: CreateProjectAndDeployTestCase[] = [
{ title: 'Ballerina', ...getBallerinaValidateOptions(), deployInputs: [/java.*11/i] },
// All C# tests on mac and .NET 6 on windows are consistently timing out for some unknown reason. Will skip for now
{ title: 'C# .NET Core 3.1', buildMachineOsToSkip: 'darwin', ...getCSharpValidateOptions('netcoreapp3.1'), createProjectInputs: [/net.*3/i], deployInputs: [/net.*3/i], createFunctionInputs: ['Company.Function'] },
{ title: 'C# .NET 5', buildMachineOsToSkip: 'darwin', ...getCSharpValidateOptions('net5.0'), createProjectInputs: [/net.*5/i], deployInputs: [/net.*5/i], createFunctionInputs: ['Company.Function'] },
{ title: 'C# .NET 6', buildMachineOsToSkip: ['darwin', 'win32'], ...getCSharpValidateOptions('net6.0', FuncVersion.v4), createProjectInputs: [/net.*6/i], deployInputs: [/net.*6/i], createFunctionInputs: ['Company.Function'] },
{ title: 'PowerShell', ...getPowerShellValidateOptions(), deployInputs: [/powershell.*7/i] },
{ title: 'Python', buildMachineOsToSkip: 'win32', ...getPythonValidateOptions('.venv'), createProjectInputs: [/3\.7/], deployInputs: [getRotatingPythonVersion()] }
Expand Down
3 changes: 0 additions & 3 deletions test/project/createNewProject.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ interface CreateProjectTestCase extends ICreateProjectTestOptions {
const testCases: CreateProjectTestCase[] = [
{ ...getCSharpValidateOptions('netcoreapp2.1', FuncVersion.v2) },
{ ...getCSharpValidateOptions('netcoreapp3.1', FuncVersion.v3), inputs: [/3/], description: 'netcoreapp3.1' },
{ ...getCSharpValidateOptions('net5.0', FuncVersion.v3), inputs: [/5/], description: 'net5.0 isolated v3' },
// /~https://github.com/Azure/azure-functions-tooling-feed/pull/289/files#r697703951
// { ...getCSharpValidateOptions('net5.0', FuncVersion.v4), inputs: [/5/], description: 'net5.0 isolated v4' },
{ ...getCSharpValidateOptions('net6.0', FuncVersion.v4), inputs: [/6/], description: 'net6.0' },
{ ...getCSharpValidateOptions('net6.0', FuncVersion.v4), inputs: [/6.*isolated/i], description: 'net6.0 isolated' },
{ ...getCSharpValidateOptions('net7.0', FuncVersion.v4), inputs: [/7.*isolated/i], description: 'net7.0 isolated' },
Expand Down
2 changes: 0 additions & 2 deletions test/templateCount.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ function addSuite(source: TemplateSource | undefined): void {
{ language: ProjectLanguage.CSharp, version: FuncVersion.v1, expectedCount: 12 },
{ language: ProjectLanguage.CSharp, version: FuncVersion.v2, expectedCount: 11 },
{ language: ProjectLanguage.CSharp, version: FuncVersion.v3, expectedCount: 12, projectTemplateKey: 'netcoreapp3.1' },
{ language: ProjectLanguage.CSharp, version: FuncVersion.v3, expectedCount: 10, projectTemplateKey: 'net5.0-isolated' },
{ language: ProjectLanguage.CSharp, version: FuncVersion.v4, expectedCount: 12, projectTemplateKey: 'net6.0' },
{ language: ProjectLanguage.CSharp, version: FuncVersion.v4, expectedCount: 10, projectTemplateKey: 'net5.0-isolated' },
{ language: ProjectLanguage.CSharp, version: FuncVersion.v4, expectedCount: 10, projectTemplateKey: 'net6.0-isolated' },
{ language: ProjectLanguage.CSharp, version: FuncVersion.v4, expectedCount: 10, projectTemplateKey: 'net7.0-isolated' },
{ language: ProjectLanguage.Python, version: FuncVersion.v2, expectedCount: 12 },
Expand Down
1 change: 0 additions & 1 deletion test/updateBackupTemplates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ suite('Backup templates', () => {
{ language: ProjectLanguage.JavaScript, versions: allVersions },
{ language: ProjectLanguage.CSharp, versions: [FuncVersion.v1, FuncVersion.v2] },
{ language: ProjectLanguage.CSharp, projectTemplateKey: 'netcoreapp3.1', versions: [FuncVersion.v3] },
{ language: ProjectLanguage.CSharp, projectTemplateKey: 'net5.0-isolated', versions: [FuncVersion.v3, FuncVersion.v4] },
{ language: ProjectLanguage.CSharp, projectTemplateKey: 'net6.0', versions: [FuncVersion.v4] },
{ language: ProjectLanguage.CSharp, projectTemplateKey: 'net6.0-isolated', versions: [FuncVersion.v4] },
{ language: ProjectLanguage.CSharp, projectTemplateKey: 'net7.0-isolated', versions: [FuncVersion.v4] },
Expand Down