Skip to content

Commit

Permalink
Change learn more label for programming model step (#3609)
Browse files Browse the repository at this point in the history
* Change learn more label for programming model step

* PR Feedback
  • Loading branch information
nturinski authored Mar 3, 2023
1 parent 8db3cec commit fc7a30c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/FuncVersion.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*--------------------------------------------------------------------------------------------*/

import { IActionContext, IAzureQuickPickItem, IAzureQuickPickOptions } from '@microsoft/vscode-azext-utils';
import { learnMoreQp } from './constants';
import { localize } from './localize';
import { openUrl } from './utils/openUrl';

Expand All @@ -29,6 +28,7 @@ export async function promptForFuncVersion(context: IActionContext, message?: st

picks = picks.filter(p => osSupportsVersion(p.data));

const learnMoreQp = { label: localize('learnMore', '$(link-external) Learn more...'), description: '', data: undefined };
picks.push(learnMoreQp);

const options: IAzureQuickPickOptions = { placeHolder: message || localize('selectVersion', 'Select a version'), stepName: 'funcVersion', suppressPersistence: true };
Expand Down
3 changes: 2 additions & 1 deletion src/commands/createNewProject/ProgrammingModelStep.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/

import { AzureWizardPromptStep, IAzureQuickPickItem, IAzureQuickPickOptions, nonNullValue, openUrl } from '@microsoft/vscode-azext-utils';
import { learnMoreQp, nodeProgrammingModelSetting } from '../../constants';
import { nodeProgrammingModelSetting } from '../../constants';
import { localize } from '../../localize';
import { getWorkspaceSetting } from '../../vsCodeConfig/settings';
import { IProjectWizardContext } from './IProjectWizardContext';
Expand All @@ -29,6 +29,7 @@ export class ProgrammingModelStep extends AzureWizardPromptStep<IProjectWizardCo
}
});

const learnMoreQp = { label: localize('learnMore', '$(link-external) Learn more about Model V4...'), description: '', data: undefined };
if (this._learnMoreLink) {
modelsPick.push(learnMoreQp);
}
Expand Down
1 change: 0 additions & 1 deletion src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,4 +172,3 @@ export const functionFilter = {
};

export const sqlBindingTemplateRegex: RegExp = /Sql.*Binding/i;
export const learnMoreQp = { label: localize('learnMore', '$(link-external) Learn more...'), description: '', data: undefined };

0 comments on commit fc7a30c

Please sign in to comment.