Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/sclouvau/bsoa master merge #2133

Merged
merged 82 commits into from
Oct 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
a1c3eab
Honor insert and remove arguments for rebase uri command. (#1927)
michaelcfanning Jun 24, 2020
2024242
Rule validaton request template (github issue) (#1903)
harleenkohli Jun 24, 2020
f563e21
rule validation template file (#1902)
harleenkohli Jun 24, 2020
f194c87
Create 'SARIF Validation Rule Authoring Principles' doc. (#1906)
Jun 24, 2020
fb04d12
Serialization Consistency fixes (#1924)
Jun 24, 2020
a84947f
Fix #1915: Allow result message to be truncated (#1932)
Jun 25, 2020
b234ef5
Upgrade netcoreapp from Multitool (#1962)
eddynaka Jul 2, 2020
44274b5
Remove extra version header from release history. (#1985)
Jul 8, 2020
d8d4cc7
Guarantee "execute" permissions for NPM package. (#1986)
jeffersonking Jul 10, 2020
2e39882
Merge feature branch with new SARIF validation rules (#1984)
Jul 10, 2020
3e6645f
marking webrequest perf test to be ignored due to its flakiness. (#1987)
harleenkohli Jul 10, 2020
79588b5
Make all Multitool command and options classes public, (#1988)
Jul 10, 2020
dc82504
Bump lodash from 4.17.14 to 4.17.19 in /src/ESLint.Formatter (#1999)
dependabot[bot] Jul 17, 2020
d9f783d
Updating SARIF2004 (#1995)
eddynaka Jul 20, 2020
f29f001
Bump version to 2.3.3; update release history. (#2006)
Jul 20, 2020
f4cf16e
Adding rule SARIF2016 (#1996)
eddynaka Jul 20, 2020
b857f62
Modify sample to use uriBaseIds (#2002)
Jul 20, 2020
09c26f5
Update release history for SARIF2016. (#2010)
Jul 20, 2020
10277da
Sarif SDK fixes during Fortify conversion comparison testing (#2011)
Jul 22, 2020
87a9746
switching test cases titles and adding a new case (#2012)
harleenkohli Jul 29, 2020
839b189
Fortify FPR converter fixes (#2014)
michaelcfanning Jul 29, 2020
239efeb
Fix #2009: Don't require per-test config files in validator functiona…
Jul 29, 2020
2ce71e3
Fix #2003: Don't report missing snippet if file content is present. (…
eddynaka Jul 29, 2020
c980b9f
Fix broken functional test. (#2020)
Jul 31, 2020
f5b98ad
Update merge command to allow splitting merged results again along a …
michaelcfanning Aug 2, 2020
bb4dee3
Introduce GitHub DSP analysis rules (#2021)
Aug 6, 2020
f0fd0c9
Include GitHub DSP policy file in MultiTool NuGet package. (#2030)
Aug 6, 2020
2d808ec
Defer loading of the filing client until it's used. (#2038)
rtaket Aug 25, 2020
42d7f47
Rename the 'guid' property to 'logId'. (#2037)
rtaket Aug 25, 2020
8a3c5cb
Add GitInformation helper. (#2035)
Aug 25, 2020
ee6ab47
Improve package creation (#2032)
Aug 25, 2020
60c8137
Revert "Improve package creation (#2032)" (#2048)
Aug 29, 2020
fe95db4
SARIF2005.ProvideToolProperties: Allow dottedQuadFileVersion; require…
Aug 31, 2020
cef88f8
Rebase absolute URIs relative to the closest enclosing repo root. (#2…
Aug 31, 2020
5519b61
Renaming DSP rules (#2049)
eddynaka Aug 31, 2020
dd96790
Rename SARIF2012 and add check for friendly name (#2031)
eddynaka Aug 31, 2020
2f7014a
Mention VersionControlInformation to Multitool help (#2051)
Sep 1, 2020
48411d6
Enable rule documentation export in multitool (#2052)
eddynaka Sep 1, 2020
ffe27f2
Minor change in ESLint.Formatter/readme.MD (#2059)
tosmolka Sep 3, 2020
e96e36c
Fix GitHubDspIngestionVisitor (#2061)
Sep 4, 2020
9870138
Extract Sarif.Multitool.Library from Sarif.Multitool (#2054)
Sep 4, 2020
8a475ce
Update GitHub brand names (#2069)
jhutchings1 Sep 14, 2020
c9e6803
Fix a couple of edge cases that cause the ESLint formatter to create …
Sep 14, 2020
c81d342
Moving ExportRuleDocumentationCommand to Driver (#2066)
eddynaka Sep 16, 2020
c6a9633
Update nuget.exe. Remove duplicate files from package. Resolve nuget.…
michaelcfanning Sep 17, 2020
9103b7f
Update release file and version for 2.3.6 (#2076)
michaelcfanning Sep 17, 2020
bece0d1
Remove package file contents duplication. (#2078)
michaelcfanning Sep 18, 2020
a22af18
ESLint.Formatter - Add ESLint version to run.tool.driver #2070 (#2071)
tosmolka Sep 18, 2020
3472a83
Refactor the SARIF Multitool unit tests (#2075)
Sep 22, 2020
5d04194
Exposing commands to multitool (#2073)
eddynaka Sep 29, 2020
2e3a11e
Adding Delete in IFileSystem (#2072)
eddynaka Sep 29, 2020
eb9d7f2
Fix #2062: LGTM "could not build merge commit" (#2067)
Sep 29, 2020
60816cb
Add explicit reference to newtonsoft. Update to 11.0.2. Update to min…
michaelcfanning Sep 30, 2020
0af14f9
Implement converter from FlawFinder's CSV output format (#2088)
Oct 5, 2020
f840364
Fix #2084 (GitHub related location message); Fix #2085 (GitHub invoca…
Oct 5, 2020
029ad61
Fixing index out of range in baseliner (#2102)
eddynaka Oct 13, 2020
062facb
Adding setter to GitExePath (#2110)
eddynaka Oct 15, 2020
e57c5ff
Checking PATH environment variable (#2107)
eddynaka Oct 15, 2020
a79bc8e
Fix #2089: GitHub policy should not turn off any note level rules (#2…
Oct 15, 2020
dfda92a
Export docs when packing (#2087)
eddynaka Oct 15, 2020
39f6131
Generalize and harden docs exporter (#2082)
eddynaka Oct 15, 2020
53b3c0c
Fix #2090: Validator should warn of leading / in relative artifact lo…
Oct 15, 2020
0a821e6
Fix up test break. Mark doc comment warnings as silent for now. (#2112)
michaelcfanning Oct 15, 2020
547da37
Fix #2098: Make pretty-print the default output format (#2100)
Oct 15, 2020
ea5a0c9
Support queries against properties in the result's and the rule's pro…
Oct 15, 2020
e77e47b
Compute and Apply policies (#2109)
eddynaka Oct 15, 2020
fa310d4
Simplifying tests and adding fix in changelog (#2111)
eddynaka Oct 16, 2020
f2108fe
Creating FileSystem singleton (#2115)
eddynaka Oct 16, 2020
93bb53b
Implementing Formatting property+ fixes (#2121)
eddynaka Oct 21, 2020
9501b1a
Adding command policy to multitool (#2118)
eddynaka Oct 21, 2020
c0995f5
Fixing xml when that doesn't contain location (#2119)
eddynaka Oct 21, 2020
a83204d
Fixing FileSpecifier for Linux/Windows environment (#2122)
eddynaka Oct 21, 2020
d4a3f71
Enforcing file normalization (#2116)
eddynaka Oct 22, 2020
df29ab7
Enabling dotnet-format in pipeline (#2123)
eddynaka Oct 22, 2020
5031da7
Reversion to 2.3.8. (#2125)
michaelcfanning Oct 23, 2020
37a7c7c
Updating badge and pre-requisites to build sarif-sdk (#2126)
eddynaka Oct 23, 2020
018374f
Improve FileRegionsCache testability (#2131)
eddynaka Oct 25, 2020
982c3ca
Merge branch 'master' into users/sclouvau/BSOA-Master-Merge, fix build.
Oct 26, 2020
0685b26
Merge correct current JSON1002 expected (one result)
Oct 26, 2020
cdf71df
Fix Skimmer translation to be more consistent with previous conversion.
Oct 26, 2020
72e6c32
Set hint to serialize Result.Locations when empty.
Oct 26, 2020
ac55f81
Update SARIF1004 Invalid example so input has same attribute order as…
Oct 26, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
47 changes: 47 additions & 0 deletions .github/ISSUE_TEMPLATE/validation-rule-request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
---
name : Validation rule request
about : A detailed specification for a new SARIF validation rule to add to the Sarif.Multitool validate command.
title : "[RULE REQUEST] Concise description of new analysis"
labels : validation-rule-request
assignees : ''

---

---

# Rule Proposal: [Friendly Rule Name]
- *Synopsis* : [Brief summary of the rule, include code snippets if possible.]

- *[Violation Example]* : [Optional, Include code snippet which should trigger the violation.]

- *[No Violation Example]* : [Optional, Include code snippet which demostrates ideal condition (no violation).]

---

### Rule metadata
- [*Id*] : [Should be formatted as `SARIF1nnn`, leave blank if unsure]
- *Name* : [Provide a friendly symbolic name for the rule in PascalCase.]
- *Level* : [Possible values are: `error`, `warning`, or `note`.]
- *Full description* : [Provide atleast two sentences. The first sentence should be a short description of the rule.
This will appear as `Short Description` in rules metadata. The other sentence(s) should
describe usage of the rule and any other relevant information.]

- User-facing strings:
[Each rule has one or more result message strings, each with symbolic name in PascalCase.]

- *FirstMessage* : [Default user facing string.]
- *[SecondMessage]* : [Optional, Any conditional user facing string(s).]
- *[ThirdMessage]* : [Optional, Any conditional user facing string(s).]

---

### Links/Additional Information
*[Optional, any Links/Additional Information.]*

### Implementation Notes
*[Optional, any suggestions regarding implementation.]*

### How to resolve
*[Optional, any tips on how to resolve the violation.]*

---
24 changes: 24 additions & 0 deletions .github/workflows/dotnet-format.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: dotnet format

on:
pull_request:
branches: [ master ]

jobs:
check-format:
runs-on: windows-latest

steps:
- name: check out code
uses: actions/checkout@v2

- name: Setup .NET Core 3.1
uses: actions/setup-dotnet@v1
with:
dotnet-version: 3.1.x

- name: Install format tool
run: dotnet tool install -g dotnet-format

- name: dotnet format
run: dotnet-format --folder --check --exclude .\src\Sarif\Autogenerated\
Binary file modified .nuget/NuGet.exe
Binary file not shown.
Binary file added .nuget/NuGet.pdb
Binary file not shown.
Loading