Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in Ghost BN in TabNet and typos in README #337

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Fix bugs in Ghost BN in TabNet and typos in README #337

merged 6 commits into from
Mar 15, 2021

Conversation

D-X-Y
Copy link
Contributor

@D-X-Y D-X-Y commented Mar 14, 2021

The original implementation of Ghost BN in TabNet is unsafe. It will crash when the input size is small than the number of ghosts, which happens in csi100.

Description

  • Fix the bugs in GBN layer in TabNet
  • Add config of TabNet on Alpha360
  • Fix typos in README

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.

Types of changes

  • Fix bugs
  • Update documentation

qlib/contrib/model/pytorch_tabnet.py Outdated Show resolved Hide resolved
qlib/contrib/model/pytorch_tabnet.py Outdated Show resolved Hide resolved
@D-X-Y D-X-Y requested review from you-n-g and Derek-Wds March 15, 2021 01:47
Copy link
Contributor

@Derek-Wds Derek-Wds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks~

@D-X-Y
Copy link
Contributor Author

D-X-Y commented Mar 15, 2021

LGTM. Thanks~

Thanks for your help.

@you-n-g you-n-g merged commit d47e35d into microsoft:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants