Skip to content

Commit

Permalink
Bumps the ACR vendored argo image versions (#310)
Browse files Browse the repository at this point in the history
* Bumps the ACR vendored argo image versions

* Bump azurite

* Adds tf attribute from private link
  • Loading branch information
mmcfarland authored Jul 22, 2024
1 parent a1d85b4 commit cf862a0
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
6 changes: 3 additions & 3 deletions deployment/helm/argo-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ server:
image:
registry: pccomponentstest.azurecr.io
repository: argoproj/argocli
tag: v3.5.7
tag: v3.5.8
controller:
image:
registry: pccomponentstest.azurecr.io
repository: argoproj/workflow-controller
tag: v3.5.7
tag: v3.5.8
executor:
image:
registry: pccomponentstest.azurecr.io
repository: argoproj/argoexec
tag: v3.5.7
tag: v3.5.8
6 changes: 5 additions & 1 deletion deployment/terraform/resources/storage_account.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ resource "azurerm_storage_account" "pctasks" {
azurerm_subnet.function_subnet.id,
azurerm_subnet.k8snode_subnet.id,
]


private_link_access {
endpoint_resource_id = "/subscriptions/a84a690d-585b-4c7c-80d9-851a48af5a50/providers/Microsoft.Security/datascanners/storageDataScanner"
endpoint_tenant_id = "72f988bf-86f1-41af-91ab-2d7cd011db47"
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: "2.1"
services:
azurite:
container_name: pctasks-azurite
image: mcr.microsoft.com/azure-storage/azurite:3.30.0
image: mcr.microsoft.com/azure-storage/azurite:3.31.0
hostname: azurite
command: "azurite --silent --blobHost 0.0.0.0 --queueHost 0.0.0.0 --tableHost
0.0.0.0 -l /workspace"
Expand Down
10 changes: 5 additions & 5 deletions docs/development/deploying.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@ The chart can be brought into the `deployment/helm/vendored` directory by runnin
```console
cd deployment/helm/vendored
helm repo add argo https://argoproj.github.io/argo-helm
helm pull argo/argo-workflows --version 3.5.7
helm pull argo/argo-workflows --version 3.5.8
```

The images can be imported into your ACR by running the following command:

```console
az acr login --name <your-acr-name>
az acr import -n pccomponentstest --source quay.io/argoproj/argocli:v3.5.7 -t argoproj/argocli:v3.5.7 --subscription "Planetary Computer Test"
az acr import -n pccomponentstest --source quay.io/argoproj/workflow-controller:v3.5.7 -t argoproj/workflow-controller:v3.5.7 --subscription "Planetary Computer Test"
az acr import -n pccomponentstest --source quay.io/argoproj/argoexec:v3.5.7 -t argoproj/argoexec:v3.5.7 --subscription "Planetary Computer Test"
az acr login --name pccomponentstest
az acr import -n pccomponentstest --source quay.io/argoproj/argocli:v3.5.8 -t argoproj/argocli:v3.5.8 --subscription "Planetary Computer Test"
az acr import -n pccomponentstest --source quay.io/argoproj/workflow-controller:v3.5.8 -t argoproj/workflow-controller:v3.5.8 --subscription "Planetary Computer Test"
az acr import -n pccomponentstest --source quay.io/argoproj/argoexec:v3.5.8 -t argoproj/argoexec:v3.5.8 --subscription "Planetary Computer Test"
```

The image and tag values are specified in the `argo-values.yaml` file and used during installs.
Expand Down

0 comments on commit cf862a0

Please sign in to comment.