Adds Telemetry for IntelliSense Levels #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug We would like to understand what IntelliSense level users are on and when they change IntelliSense levels. This will help us identify adoption of the ES6 analyzer as well as any potential issues keeping people on the old analyzer. It also helps us plan the phase out of the old analyzer Fix Adds two telemetry points: * IntelliSenseLevelChanged - General, IntelliSense level has changed event. Sent when user changes the level through the options. * IntelliSenseActivatedForProject - Logged for each project when the project is first loaded or when the intellisense level is changed. Closes microsoft#1096
| @@ -20,5 +20,7 @@ namespace Microsoft.NodejsTools.Telemetry { | |||
| /// </summary> | |||
| internal static class TelemetryEvents { | |||
| public const string ProjectImported = "ProjectImported"; | |||
| public const string IntelliSenseActivatedForProject = "IntelliSenseActivatedForProject"; | |||
There was a problem hiding this comment.
Should this be AnalysisLevel instead? We seem to use IntelliSense level or IntelliSense mode in the UI and documentation, but analysis level in the code.
There was a problem hiding this comment.
Yep AnalysisLevel would be better for consistency. For technical discussions, we typically make a distinction between "IntelliSense" - the VS-branded user experience - and the actual engine that's providing the code intelligence.
|
Left a few comments and 👍 after that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
We would like to understand what IntelliSense level users are on and when they change IntelliSense levels. This will help us identify adoption of the ES6 analyzer as well as any potential issues keeping people on the old analyzer. It also helps us plan the phase out of the old analyzer
Fix
Adds two telemetry points:
These events are both implemented using helper extension methods on
NodejsPackage.Instance.TelemetryLogger. This unifies and hides the actual logging logic. I also updatedLogProjectImportedto use this style of logging.Closes #1096