This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore: move customProptypes to a separate package
#921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Feb 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
- Coverage 81.94% 81.78% -0.17%
==========================================
Files 702 702
Lines 8580 8580
Branches 1245 1172 -73
==========================================
- Hits 7031 7017 -14
- Misses 1534 1548 +14
Partials 15 15
Continue to review full report at Codecov.
|
Changed dependencies in
Generated by 🚫 dangerJS |
kuzhelov
reviewed
Feb 20, 2019
kuzhelov
reviewed
Feb 20, 2019
kuzhelov
reviewed
Feb 20, 2019
.github/CONTRIBUTING.md
Outdated
| #### Update `package.json` | ||
|
|
||
| After a package will be created we need to add necessary changes to a newly created `package.json`. | ||
| These changes are required to get working package publishing and internal tooling. |
There was a problem hiding this comment.
nit: These changes are required to setup internal tooling and package publishing
kuzhelov
reviewed
Feb 20, 2019
kuzhelov
reviewed
Feb 20, 2019
kuzhelov
reviewed
Feb 20, 2019
| @@ -4,7 +4,7 @@ import * as prettier from 'prettier' | |||
| import * as through from 'through2' | |||
| import * as Vinyl from 'vinyl' | |||
|
|
|||
| import * as prettierConfig from '../../../.prettierrc.json' | |||
| const prettierConfig = require('../../../.prettierrc.json') | |||
There was a problem hiding this comment.
could you, please, suggest why this change was necessary?
There was a problem hiding this comment.
Now we have a specific tsconfig.json for react-proptypes that doesn't include /build directory, so it will fail with:
../../build/gulp/plugins/gulp-example-source.ts(7,33): error TS2732: Cannot find modu
le '../../../.prettierrc.json'. Consider using '--resolveJsonModule' to import module
with '.json' extension
Did I miss something?
kuzhelov
reviewed
Feb 20, 2019
kuzhelov
reviewed
Feb 20, 2019
kuzhelov
reviewed
Feb 20, 2019
kuzhelov
approved these changes
Feb 20, 2019
|
Marking as blocked as we decided to include these changes to a release after the next. |
…tardust-ui/react into chore/proptypes # Conflicts: # packages/react/package.json
…tardust-ui/react into chore/proptypes # Conflicts: # packages/react/package.json
…tardust-ui/react into chore/proptypes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #433.
customPropTypesto a separate package