-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runtime] Add return values to transmit and receive in the network runtime #1363
Conversation
libos = catpowder
|
libos = catnip
|
libos = catnap
|
1abffc7
to
0e4b947
Compare
libos = catpowder
|
libos = catnip
|
libos = catnap
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Overall looks good and we can merge it.
In summary, I left two suggestions:
- Change the error codes that we use to signal runtime errors.
- Retry sending on some places when we hit a runtime error.
0e4b947
to
011c4fa
Compare
libos = catpowder
|
libos = catnap
|
libos = catnip
|
This PR adds return values to the transmit and receive functions in the network runtime trait, so that we can remove panics and silent errors to return a value.