Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shim] Bad Initialization for vfcntl(), epoll_ctl(), epoll_wait() and epoll_create() #1358

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

ppenna
Copy link
Collaborator

@ppenna ppenna commented Aug 5, 2024

Description

This PR isolates some changes introduced by #1351.

@ppenna ppenna self-assigned this Aug 5, 2024
@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

libos = catpowder
commit id = ccd9b88

collapsed_stack percent_time cycles_per_call nanoseconds_per_call
ioc::network::libos::pushto;inetstack::push 88.90 4716.97 2043.77
ioc::network::libos::push;inetstack::push 88.45 6354.13 2948.35
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::receive 77.43 901.80 400.23
bgc::inetstack::poll_recv;inetstack::poll;inetstack::poll_bg_work::for::receive 76.51 7761.77 3463.80
bgc::inetstack::poll_recv 63.54 1229.54 546.04
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;inetstack::receive;udp::receive 55.80 350.24 146.36
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 33.11 1742.59 735.06
demikernel::new 26.30 98604559.37 43526047.29
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 25.55 1252.98 550.47
bgc::inetstack::tcp::established::background;tcp::established::background::sender 18.58 840.72 369.69
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;inetstack::receive 15.21 850.11 374.88
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 7.95 377.14 166.67
bgc::inetstack::tcp::established::background 6.55 4543.43 1969.25
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 4.49 62.42 27.84
ioc::network::libos::push 3.48 6633.70 3073.72
bgc::inetstack::poll_recv;inetstack::poll;inetstack::poll_bg_work::for::for 3.33 321.93 144.40
ioc::network::libos::pushto 2.52 5306.02 2298.99
ioc::network::libos::pop 1.10 1024.32 453.04
demikernel::push 0.30 861.03 393.10
ioc::network::libos::connect 0.29 24634.76 11287.07
demikernel::pushto 0.24 498.02 215.31
ioc::network::libos::close 0.21 12752.59 5709.48
demikernel::pop 0.16 577.92 253.89
demikernel::sgaalloc 0.10 146.99 66.74
bgc::inetstack::poll_recv;inetstack::poll 0.05 10037.00 4472.75
demikernel::sgafree 0.04 85.44 38.39
bgc::inetstack::tcp::passiveopen::background 0.01 13594.12 6288.53
demikernel::connect 0.01 4905.34 2303.68
demikernel::async_close 0.01 666.72 274.17
demikernel::bind 0.00 11180.25 4914.06
demikernel::listen 0.00 6744.29 3007.06
bgc::passive_listening::poll 0.00 5499.09 2503.62
bgc::inetstack::icmp::background 0.00 3349.28 1487.36
ioc::network::libos::accept 0.00 2738.94 1262.17
bgc::inetstack::arp::background 0.00 2387.40 1057.22
demikernel::accept 0.00 1519.34 691.32
demikernel::socket 0.00 1395.21 623.87
demikernel::close 0.00 nan nan

Copy link

github-actions bot commented Aug 5, 2024

libos = catnip
commit id = ccd9b88

collapsed_stack percent_time cycles_per_call nanoseconds_per_call
bgc::inetstack::poll_recv;inetstack::poll;inetstack::poll_bg_work::for::receive;catnip::runtime::receive 97.93 18085.62 7664.88
bgc::inetstack::poll_recv;inetstack::poll;inetstack::poll_bg_work::for::receive 86.30 18463.43 7824.79
ioc::network::libos::push;inetstack::push 71.28 1726.95 732.34
bgc::inetstack::poll_recv;inetstack::poll;inetstack::poll_bg_work::for::for;inetstack::receive 70.71 2122.28 905.35
ioc::network::libos::pushto;inetstack::push 69.40 982.06 417.99
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::receive;catnip::runtime::receive 66.17 199.29 84.63
demikernel::new 60.75 1814527568.65 770099431.89
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;inetstack::receive;udp::receive 57.76 390.03 173.47
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::receive 55.44 300.94 127.77
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 49.77 873.75 370.94
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 44.87 19953.19 8350.03
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 41.69 409.39 174.45
bgc::inetstack::poll_recv 35.70 571.57 243.01
ioc::network::libos::connect;catnip::runtime::transmit 30.58 6469.36 2841.55
bgc::inetstack::tcp::established::background;tcp::established::background::receiver 27.95 850.96 356.48
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 26.40 1084.43 455.10
bgc::inetstack::tcp::established::background;tcp::established::background::sender 20.01 757.62 319.09
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;inetstack::receive 13.30 852.51 360.35
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 9.63 58.92 25.21
ioc::network::libos::close;catnip::runtime::transmit 9.52 895.38 378.36
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 8.30 316.81 133.37
bgc::inetstack::poll_recv;inetstack::poll;inetstack::poll_bg_work::for::for 8.27 1763.48 750.19
bgc::inetstack::tcp::established::background;tcp::established::background::receiver;catnip::runtime::transmit 8.01 1114.83 463.00
bgc::inetstack::tcp::established::background 2.74 3277.23 1375.86
ioc::network::libos::push 0.54 2257.15 957.38
ioc::network::libos::pop 0.52 908.26 382.58
bgc::inetstack::poll_recv;inetstack::poll 0.27 42768.27 18128.41
demikernel::push 0.15 673.69 286.57
ioc::network::libos::pushto 0.06 1413.18 601.46
demikernel::pop 0.06 446.62 190.42
demikernel::sgaalloc 0.05 146.18 63.82
demikernel::pushto 0.02 455.30 194.19
ioc::network::libos::connect 0.01 15256.30 6658.62
ioc::network::libos::close 0.01 7495.68 3208.49
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 0.01 894.25 376.37
demikernel::sgafree 0.01 65.91 27.94
demikernel::bind 0.00 21900.56 8911.80
bgc::inetstack::tcp::passiveopen::background 0.00 15151.04 6315.94
bgc::passive_listening::poll 0.00 5768.43 2397.29
demikernel::listen 0.00 4119.21 1707.33
demikernel::connect 0.00 3971.99 1720.39
demikernel::socket 0.00 3218.99 1344.79
bgc::inetstack::icmp::background 0.00 3114.12 1322.60
bgc::inetstack::arp::background 0.00 2556.94 1076.52
ioc::network::libos::accept 0.00 2536.75 1051.84
demikernel::accept 0.00 1226.23 508.89
demikernel::async_close 0.00 585.96 244.04
demikernel::close 0.00 nan nan

Copy link

github-actions bot commented Aug 5, 2024

libos = catnap
commit id = ccd9b88

collapsed_stack percent_time cycles_per_call nanoseconds_per_call
demikernel::socket;catnap::linux::transport::socket 97.73 52829.61 22693.47
ioc::network::libos::close;catnap::linux::transport::close 95.91 22453.04 9663.37
demikernel::listen;catnap::linux::transport::listen 92.46 12775.66 5483.86
demikernel::bind;catnap::linux::transport::bind 81.92 23759.32 10212.79
ioc::network::libos::accept 43.61 897199337.37 387764292.66
bgc::catnap::transport::epoll 33.74 2328.86 1003.24
ioc::network::libos::pop 25.76 5812418.96 2410023.68
ioc::network::libos::connect 23.94 4413152.15 1921598.94
ioc::network::libos::pushto 22.68 11745.33 4882.29
ioc::network::libos::push 6.62 17189.85 7449.98
ioc::network::libos::pushto;catnap::linux::transport::push 6.52 755.11 313.71
ioc::network::libos::push;catnap::linux::transport::push 4.47 735.94 320.60
ioc::network::libos::pop;catnap::linux::transport::pop 2.16 530.65 228.54
ioc::network::libos::connect;catnap::linux::transport::connect 1.96 55932.78 24403.05
demikernel::pushto 1.09 611.10 253.60
demikernel::new 0.61 1654991.05 710410.56
demikernel::sgaalloc 0.20 236.97 102.26
demikernel::push 0.17 527.13 227.92
demikernel::pop 0.11 636.02 270.97
demikernel::socket 0.09 54058.28 23224.70
ioc::network::libos::close 0.07 23456.19 10095.38
demikernel::sgafree 0.04 78.00 33.30
demikernel::async_close 0.02 872.89 352.73
demikernel::bind 0.01 29022.60 12471.97
demikernel::connect 0.01 3516.18 1567.55
demikernel::listen 0.00 13802.42 5924.06
ioc::network::libos::accept;catnap::linux::transport::accept 0.00 2972.89 1276.84
demikernel::accept 0.00 1864.72 810.50
demikernel::close 0.00 nan nan

@ppenna ppenna marked this pull request as ready for review August 5, 2024 17:23
@ppenna
Copy link
Collaborator Author

ppenna commented Aug 5, 2024

Bypassing this review as it concerns the SHIM Layer and PR #1351.

@ppenna ppenna merged commit f1adef8 into dev Aug 5, 2024
19 checks passed
@ppenna ppenna deleted the bugfix-shim-init branch August 5, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant