Support recommended completion for union #24326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
completionsRecommended_union
branch
from
210d8b8 to
5d522b1
Compare
mhegazy
approved these changes
May 22, 2018
| { | ||
| marker: "b", | ||
| // Arbitrarily chooses one to be recommended | ||
| includes: [{ name: "E", isRecommended: true, }, { name: "E2" }], |
There was a problem hiding this comment.
Why not E2 to be recommended as well?
There was a problem hiding this comment.
In the original design (#20020) there can only be one recommended completion -- editors may be expecting this. We could add more than one but it would mean more work for editors and I think that's why we avoided it.
sheetalkamat
approved these changes
May 22, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24304