Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIRV] Add support of the GL_EXT_spirv_intrinsics #4035

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

jiaolu
Copy link
Contributor

@jiaolu jiaolu commented Oct 25, 2021

related to
issue:#3919

Add support to these two attributes:
[[vk::ext_decorate(decoration, … int literal)]]
[[vk::ext_decorate_string(decoration, … string literals)]]

@AppVeyorBot
Copy link

related to
issue:microsoft#3919

Add support to these two attributes:
 [[vk::ext_decorate(decoration, … int literal)]]
 [[vk::ext_decorate_string(decoration, … string literals)]]
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@jiaolu jiaolu changed the title RV] Add support of the GL_EXT_spirv_intrinsics [SPIRV] Add support of the GL_EXT_spirv_intrinsics Oct 26, 2021
@jaebaek jaebaek self-requested a review October 26, 2021 21:00
@jaebaek jaebaek self-assigned this Oct 26, 2021
@jaebaek jaebaek added the spirv Work related to SPIR-V label Oct 26, 2021
Copy link
Collaborator

@jaebaek jaebaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on it!
I have some comments. If you have any things unclear, please let me know.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Copy link
Collaborator

@jaebaek jaebaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating it based on my feedback. I am sorry for my misunderstanding about avoiding the location decoration assignment. I added a different suggestion in the above comment. PTAL!

@jiaolu jiaolu force-pushed the dev branch 2 times, most recently from 3272ee6 to ab74aa9 Compare October 29, 2021 06:10
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Copy link
Collaborator

@jaebaek jaebaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for your contribution. Allowing developers to test arbitrary SPIR-V is a big advance for Vulkan community!

@jaebaek jaebaek merged commit 1629096 into microsoft:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spirv Work related to SPIR-V
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants