-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIRV] Add support of the GL_EXT_spirv_intrinsics #4035
Conversation
✅ Build DirectXShaderCompiler 1.0.718 completed (commit 1338d2a111 by @jiaolu) |
related to issue:microsoft#3919 Add support to these two attributes: [[vk::ext_decorate(decoration, … int literal)]] [[vk::ext_decorate_string(decoration, … string literals)]]
✅ Build DirectXShaderCompiler 1.0.719 completed (commit f5d77b40a3 by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.720 completed (commit 103b658ead by @jiaolu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on it!
I have some comments. If you have any things unclear, please let me know.
✅ Build DirectXShaderCompiler 1.0.738 completed (commit b4d32f042e by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.739 completed (commit fe1b683156 by @jiaolu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating it based on my feedback. I am sorry for my misunderstanding about avoiding the location decoration assignment. I added a different suggestion in the above comment. PTAL!
3272ee6
to
ab74aa9
Compare
✅ Build DirectXShaderCompiler 1.0.747 completed (commit bd8e425a7a by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.748 completed (commit ec589c42eb by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.749 completed (commit 3d532693c0 by @jiaolu) |
✅ Build DirectXShaderCompiler 1.0.750 completed (commit a81014d31c by @jiaolu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks again for your contribution. Allowing developers to test arbitrary SPIR-V is a big advance for Vulkan community!
related to
issue:#3919
Add support to these two attributes:
[[vk::ext_decorate(decoration, … int literal)]]
[[vk::ext_decorate_string(decoration, … string literals)]]