Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore time in did:x509 resolve #6576

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Ignore time in did:x509 resolve #6576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c54c540
Ignore time in did:x509 resolve
achamayou Oct 17, 2024
c513450
fmt
achamayou Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .snpcc_canary
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
/-xXx--//-----x=x--/-xXx--/---x---->>>--/
...
/\/\d(-_-)b/\/\
--
--/\
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added

- Introduced `ccf::describe_cose_endorsements_v1(receipt)` for COSE-endorsements chain of previous service identities (#6500).
- Ignore time when resolving did:x509 against x5chain, resolution establishes a point-in-time endorsement, not ongoing validity (#6575).

## [6.0.0-dev1]

Expand Down
3 changes: 2 additions & 1 deletion src/node/uvm_endorsements.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ namespace ccf

const auto& did = phdr.iss;

auto did_document_str = didx509::resolve(pem_chain, did);
auto did_document_str =
didx509::resolve(pem_chain, did, true /* ignore time */);
did::DIDDocument did_document = nlohmann::json::parse(did_document_str);

if (did_document.verification_method.empty())
Expand Down