-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLog Target support ConnectionString with isolated TelemetryClient #2897
base: main
Are you sure you want to change the base?
Conversation
3e910a9
to
df34463
Compare
@cijothomas + @rajkumar-rangaraj + @TimothyMothra Fork of #2858 where I have changed to use isolated I don't mind also fixing log4net-appender if you like. Thus moving away from using Please review and merge. |
With all due respect, we are eagerly awaiting this change as the deadline for discontinuing instrumentation keys is approaching. |
Adding new methods to Public Api
@TimothyMothra Polite poke for review. Notice I don't mind updating log4net-appender as well (in new pull-request) |
Resolves #2714 - Add support for connection string to Microsoft.ApplicationInsights.NLogTarget
Changes
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors: