Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK connection string #1187

Merged
merged 69 commits into from
Sep 24, 2019
Merged

SDK connection string #1187

merged 69 commits into from
Sep 24, 2019

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Aug 2, 2019 •
edited
Loading

#1221

Ruleset

  1. check for explicit endpoint (location is ignored)
  2. check for endpoint suffix (location is optional)
  3. use classic endpoint (location is ignored)

Design

  • New property: TelemetryConfiguration.ConnectionString
  • New method: TelemetryConfiguration.SetConnectionString())
    Connection string needs to be parsed (via EndpointProvider) and validated.
    This method will set TelemetryConfiguration.InstrumentationKey.
    Resulting endpoints are set to TelemetryConfiguration.Endpoints (EndpointContainer).
    This method will also update TelemetryChannel.Endpoint
  • Contains about 220 new Tests.

@TimothyMothra TimothyMothra added this to the 2.12 milestone Aug 2, 2019
@pharring
Copy link
Member

pharring commented Aug 2, 2019

@jemodyMS @clguimanMSFT FYI

@TimothyMothra TimothyMothra marked this pull request as ready for review September 23, 2019 23:10
@TimothyMothra
Copy link
Member Author

@lmolkova Can you please re-review? You're currently blocking this PR. :)

@TimothyMothra TimothyMothra changed the title [WIP] SDK connection string SDK connection string Sep 23, 2019
@TimothyMothra TimothyMothra merged commit ed4cc44 into develop Sep 24, 2019
cijothomas
cijothomas reviewed Sep 24, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/Implementation/TelemetryConfigurationFactory.cs Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/Implementation/TelemetryConfigurationFactory.cs Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/Implementation/Tracing/CoreEventSource.cs Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/Implementation/Endpoints/EndpointContainer.cs Show resolved Hide resolved
src/ServerTelemetryChannel/ServerTelemetryChannel.cs Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs Show resolved Hide resolved
src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs Show resolved Hide resolved
@TimothyMothra TimothyMothra mentioned this pull request Oct 24, 2019
Closed
@TimothyMothra TimothyMothra deleted the tilee/connectionString branch November 15, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang left review comments

@pharring pharring pharring left review comments

@cijothomas cijothomas cijothomas left review comments

@Dmitry-Matveev Dmitry-Matveev Dmitry-Matveev approved these changes

@juliusl juliusl juliusl approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees
No one assigned
Labels
config file
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.
7 participants
@TimothyMothra @pharring @reyang @lmolkova @cijothomas @juliusl @Dmitry-Matveev