Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Springbootstarter findbugs fixes #947

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Springbootstarter findbugs fixes #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89348ca
should be static inner class
littleaj Jun 12, 2019
a2743bb
constants should be static
littleaj Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/java/com/microsoft/applicationinsights/autoconfigure/ApplicationInsightsProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ void processAndLoadJmxCounters(List<String> jmxCounterList) {
/**
* This Internal class is used to represent the Jmx Object Structure
*/
private class CompositeJmxData {
private static class CompositeJmxData {
String displayName;
String objectName;
String attributeName;
Expand Down
8 changes: 4 additions & 4 deletions ...soft/applicationinsights/autoconfigure/HeartBeatProvider/SpringBootHeartBeatProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ public class SpringBootHeartBeatProvider implements HeartBeatPayloadProviderInte
/**
* Name of this provider.
*/
private final String name = "SpringBootProvider";
private static final String name = "SpringBootProvider";

private final String SPRING_BOOT_VERSION = "ai.spring-boot.version";
private static final String SPRING_BOOT_VERSION = "ai.spring-boot.version";

private final String SPRING_VERSION = "ai.spring.version";
private static final String SPRING_VERSION = "ai.spring.version";

private final String SPRING_BOOT_STARTER_VERSION = "ai.spring.boot.starter.version";
private static final String SPRING_BOOT_STARTER_VERSION = "ai.spring.boot.starter.version";



Expand Down