Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[starter-web-netty] CORS_ALLOWED_ORIGIN config property #219

Merged
merged 2 commits into from
May 11, 2020
Merged

[starter-web-netty] CORS_ALLOWED_ORIGIN config property #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe46505
[starter-web-netty] Add env config property with default for cors all…
eahrold May 6, 2020
b3971f0
[starter-web-netty] escape default CORS_ALLOWED_ORIGIN env variable.
eahrold May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions starter-web-netty/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ Or with RapiDoc:

http://localhost:8080/swagger/views/rapidoc/index.html

To enable CORS for local development, you may specify the local host/port
```cmd
export CORS_ALLOWED_ORIGIN=https://localhost:3000 && ./gradlew starter-web-netty:run
```
## Google Cloud Run Deployment

From the project root build the docker image and push it to Google Container Registry:
Expand Down
2 changes: 1 addition & 1 deletion starter-web-netty/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ micronaut:
configurations:
web:
allowedOrigins:
- ^http(|s):\/\/micronaut\.io$
- ${CORS_ALLOWED_ORIGIN:`^http(|s):\/\/micronaut\.io$`}
allowedMethods:
- GET
gcp:
Expand Down