Add default factoryType tag for consistency in CommonsObjectPool2Metrics

micrometer-metrics · Jul 31, 2024 · b9f7ca9 · b9f7ca9
1 parent facf3ea
commit b9f7ca9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/...ain/java/io/micrometer/core/instrument/binder/commonspool2/CommonsObjectPool2Metrics.java b/...ain/java/io/micrometer/core/instrument/binder/commonspool2/CommonsObjectPool2Metrics.java
@@ -129,12 +129,16 @@ public void bindTo(@NonNull MeterRegistry registry) {
 
     private Iterable<Tag> nameTag(ObjectName name, String type)
             throws AttributeNotFoundException, MBeanException, ReflectionException, InstanceNotFoundException {
+
         Tags tags = Tags.of("name", name.getKeyProperty("name"), "type", type);
+        String factoryType = "none"; // Default value for factoryType if not available
+
         if (Objects.equals(type, "GenericObjectPool")) {
             // for GenericObjectPool, we want to include the name and factoryType as tags
-            String factoryType = mBeanServer.getAttribute(name, "FactoryType").toString();
-            tags = Tags.concat(tags, "factoryType", factoryType);
+            factoryType = mBeanServer.getAttribute(name, "FactoryType").toString();
         }
+
+        tags = Tags.concat(tags, "factoryType", factoryType);
         return tags;
     }