Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set.mm check #143

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Fix set.mm check #143

merged 2 commits into from
Sep 30, 2023

Conversation

jkingdon
Copy link
Contributor

First of all, use the develop branch rather than the master branch because the latter is rather old and we haven't been using it.

Second of all, add --verify-markup and --parse-typesetting so that we run more of the checks (including most notably the ones which the set.mm automated checks enable).

This pull request replaces #135 which was the first attempt at this.

jkingdon and others added 2 commits September 30, 2023 09:37
First of all, use the develop branch rather than the master branch
because the latter is rather old and we haven't been using it.

Second of all, add --verify-markup and --parse-typesetting so that we
run more of the checks (including most notably the ones which the set.mm
automated checks enable).
@jkingdon
Copy link
Contributor Author

I also cherry-picked over @digama0 's change with respect to \r\n line endings (which I looked over fairly quickly; the basic concept of allowing a variety of line endings seems plausible to me).

Copy link
Collaborator

@tirix tirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@digama0 digama0 merged commit fe5e7fc into metamath:main Sep 30, 2023
@jkingdon jkingdon deleted the setmm-develop branch September 30, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants