-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Revert "Remove Metal3Machine owner reference from BMH" #2254
🐛 Revert "Remove Metal3Machine owner reference from BMH" #2254
Conversation
Skipping CI for Draft Pull Request. |
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
1st run: both succeeded. Looks like we have culprit found. /test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
/retest |
/test |
@tuminoid: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
This reverts commit 715a0d0. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
72fafe6
to
20af558
Compare
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
/cc @kashifest @lentzi90 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This reverts commit 715a0d0 from #1742
For currently unknown reason, this breaks pivoting. Despite adding the move labels to BMH, something is not moved or the move order is random and relationships are not properly reconciled after move. Move works like 10% of the time, so technically it works, but clearly timing or random affects it. This must be figured out before reapplying the change.