Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert "Remove Metal3Machine owner reference from BMH" #2254

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 17, 2025

This reverts commit 715a0d0 from #1742

For currently unknown reason, this breaks pivoting. Despite adding the move labels to BMH, something is not moved or the move order is random and relationships are not properly reconciled after move. Move works like 10% of the time, so technically it works, but clearly timing or random affects it. This must be figured out before reapplying the change.

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@tuminoid
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2025
@tuminoid
Copy link
Member Author

1st run: both succeeded. Looks like we have culprit found.

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member Author

/retest

@tuminoid
Copy link
Member Author

/test
Network flake again

@metal3-io-bot
Copy link
Contributor

@tuminoid: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build
/test generate
/test gomod
/test manifestlint
/test markdownlint
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
/test shellcheck
/test test
/test unit

The following commands are available to trigger optional jobs:

/test metal3-centos-e2e-basic-test-main
/test metal3-centos-e2e-feature-test-main-features
/test metal3-centos-e2e-feature-test-main-pivoting
/test metal3-centos-e2e-feature-test-main-remediation
/test metal3-centos-e2e-feature-test-main-scalability
/test metal3-e2e-1-29-1-30-upgrade-test-main
/test metal3-e2e-clusterctl-upgrade-test-main
/test metal3-ubuntu-e2e-basic-test-main
/test metal3-ubuntu-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-feature-test-main-pivoting
/test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

build
generate
gomod
manifestlint
unit

In response to this:

/test
Network flake again

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

/retest

This reverts commit 715a0d0.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/revert-ownerref-changes branch from 72fafe6 to 20af558 Compare January 17, 2025 15:26
@tuminoid tuminoid changed the title DNM: Revert "Remove Metal3Machine owner reference from BMH" ♻️ Revert "Remove Metal3Machine owner reference from BMH" Jan 17, 2025
@tuminoid tuminoid marked this pull request as ready for review January 17, 2025 15:27
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@tuminoid tuminoid changed the title ♻️ Revert "Remove Metal3Machine owner reference from BMH" 🐛 Revert "Remove Metal3Machine owner reference from BMH" Jan 17, 2025
@tuminoid
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member Author

/cc @kashifest @lentzi90

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2025
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@metal3-io-bot metal3-io-bot merged commit 29320fa into metal3-io:main Jan 20, 2025
32 of 34 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/revert-ownerref-changes branch January 20, 2025 06:22
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants