Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library. The current version holds 3 memory leaks tho.
Chart::dispose
Neither the current widget layers, nor the old layers are disposed by the regular lifecycle events.
This may not be a problem, as all memory is most likely is to be freed, when the AnimationController dispose is called- but you never know.
ChartLineDataItem::dispose
You forgot to call dispose the touch events.
Chart::didUpdateWidget
When calling
setState
and start the animation you forget to dispose thoseCurvedAnimation
s, which then are registered on the AnimationHandler.Also, setting the
_animation
member tonull
is basically a no-op, as need to dispose the animation. I have included a screenshot where you can easily see the insane big amount of closures held by theAnimationController
.The leaking observer, then has to update for too many listeners resulting in poor performance.