Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test execution on Chrome browser. Updated grunt, grunt plugins. Fixed new ESLint warning. #890

Merged
merged 2 commits into from
Jul 3, 2017

Conversation

kibertoad
Copy link
Contributor

No description provided.

@kibertoad kibertoad changed the title Updated grunt, grunt plugins and fixed new ESLint warning. Updated grunt, grunt plugins. Fixed new ESLint warning. Added tests execution on Chrome browser. Jul 1, 2017
@kibertoad kibertoad changed the title Updated grunt, grunt plugins. Fixed new ESLint warning. Added tests execution on Chrome browser. Updated grunt, grunt plugins. Fixed new ESLint warning. Added test execution on Chrome browser. Jul 1, 2017
@kibertoad
Copy link
Contributor Author

3 tests are failing when executed on Chrome, but I'm not sure if that's not due to differences between PhantomJS and Chrome. Those can be looked at separately.

@kibertoad kibertoad changed the title Updated grunt, grunt plugins. Fixed new ESLint warning. Added test execution on Chrome browser. Added test execution on Chrome browser. Updated grunt, grunt plugins. Fixed new ESLint warning. Jul 1, 2017
@obiot
Copy link
Member

obiot commented Jul 3, 2017

wow, that's great ! I was actually looking at karma the other day and was wondering if it would work as well with the travis build process (In this case Chrome is not really headless, compared to phantomJS)

@obiot obiot merged commit 6f7b8a8 into melonjs:master Jul 3, 2017
@obiot
Copy link
Member

obiot commented Jul 3, 2017

failing tests are on:

Chrome 59.0.3071 (Windows 10 0.0.0) ES6 Collections test Map#set FAILED
        Expected true to equal false.
            at Object.<anonymous> (tests/spec/es6-collections.js:163:22)
        Expected Function to be undefined.
            at Object.<anonymous> (tests/spec/es6-collections.js:165:22)
        Expected Object({  }) not to equal Object({  }).
            at Object.<anonymous> (tests/spec/es6-collections.js:169:27)
Chrome 59.0.3071 (Windows 10 0.0.0) ES6 Collections test Map#forEach with mutations FAILED
        Expected undefined to equal '[1,3,0]'.
            at Object.<anonymous> (tests/spec/es6-collections.js:260:39)
Chrome 59.0.3071 (Windows 10 0.0.0) me.input Pointer Event PointerDown event triggering FAILED
        Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
Chrome 59.0.3071 (Windows 10 0.0.0): Executed 286 of 289 (3 FAILED) (skipped 3) (7.448 secs / 7.433 secs)

@kibertoad
Copy link
Contributor Author

@obiot Note the karma-runner/karma-chrome-launcher#111 -> karma-chrome-launcher used in this PR already includes the 111, so making this CI-friendly should be a matter of just specifying a different launcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants