This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Genericize invalid username or password message #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#133 The message given to the user upon an invalid login attempt, for security reasons, should not reveal that the username or password was incorrect. Rather, a generic message should be displayed when the username or password is incorrect.
Closed
amoshaviv
added a commit
that referenced
this pull request
Oct 7, 2014
Genericize invalid username or password message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue 133:
If the user has an invalid username or password, the message returned should not specify if the username or password was incorrect, rather, the message should be generic for both cases.