[#2966] Refactor logic for registering contactmomenten in eSuite #1552
+611
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
3 times, most recently
from
c6d86d2 to
3928ecc
Compare
pi-sigma
changed the title
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
3 times, most recently
from
c419675 to
65f542b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1552 +/- ##
===========================================
+ Coverage 94.23% 94.24% +0.01%
===========================================
Files 1070 1076 +6
Lines 39412 39544 +132
===========================================
+ Hits 37140 37270 +130
- Misses 2272 2274 +2 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
65f542b to
58976f2
Compare
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
2 times, most recently
from
852c6ae to
14d8bd4
Compare
added 2 commits
January 20, 2025 14:29
- move relevant fields from ESuiteKlantConfig to global
KlantenSysteemConfig so they can be used for OpenKlant2
as well
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
14d8bd4 to
a2d86c1
Compare
pi-sigma
force-pushed
the
task/2966-openklant2-zaak-questions
branch
from
a2d86c1 to
12267c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding support for registering questions with OpenKlant2, the existing logic for registering contactmomenten in the eSuite is refactored.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2966