add wasm example #16
Open
add wasm example #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
maxwase
requested changes
Jul 18, 2024
| align-items: center; | ||
| width: 200px; | ||
| height: 100px; | ||
| background-color: lightgray; |
There was a problem hiding this comment.
Let's not override the default style to have a standard "animation" visible
Comment on lines
+19
to
+21
| <div class="clickable-area"> | ||
| <span>Press Area</span> | ||
| </div> |
There was a problem hiding this comment.
Let's change this to
Suggested change
| <div class="clickable-area"> | |
| <span>Press Area</span> | |
| </div> | |
| <button class="clickable-area" type="button">Button</button> |
| } | ||
|
|
||
| #[derive(Clone, Default)] | ||
| struct MockButtonPin(Rc<RefCell<bool>>); |
There was a problem hiding this comment.
I don't feel like it is a mock, let's change the name to ButtonInput or something
|
|
||
| impl WasmInstant { | ||
| fn now() -> WasmInstant { | ||
| WasmInstant(Date::now() as u64) |
There was a problem hiding this comment.
Thank you for this! I think you can even implement impl InstantProvider<Duration> for Date in the crate istef and guard it by a feature "wasm" as it already implements Sub
| @@ -0,0 +1,117 @@ | |||
| use std::{cell::RefCell, ops::Sub, rc::Rc, time::Duration}; | |||
There was a problem hiding this comment.
Could you please add a top-level comment similar to other examples? For example how to run this (trunk serve?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.