Sync with starter template: dynamic versions #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with most of the latest code from /~https://github.com/mattermost/mattermost-plugin-starter-template, with the key addition being the dynamic version computation from recent tags. Fixes: https://mattermost.atlassian.net/browse/MM-55492 Relates-to: https://mattermost.atlassian.net/browse/MM-55488
lieut-data
added
2: Dev Review
lieut-data
commented
Dec 12, 2023
| @@ -57,14 +57,18 @@ func (m *Monitor) checkChannelsSubscriptions(msteamsSubscriptionsMap map[string] | |||
| // Check if channel subscription is present for a link on Mattermost | |||
| if mmSubscriptionFound { | |||
| // Check if channel subscription is not present on MS Teams | |||
| if _, msteamsSubscriptionFound := msteamsSubscriptionsMap[mmSubscription.SubscriptionID]; !msteamsSubscriptionFound { | |||
| _, msteamsSubscriptionFound := msteamsSubscriptionsMap[mmSubscription.SubscriptionID] | |||
There was a problem hiding this comment.
Only one linting change "required", and seems to be idiomatic as per https://go.dev/doc/effective_go#switch. Extra eyes appreciated :)
cpoile
approved these changes
Dec 13, 2023
mickmister
approved these changes
Dec 14, 2023
lieut-data
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fewer changes relative to the starter-template, but incorporate mattermost/mattermost-plugin-starter-template#192 so we can tag and get the right version automatically on build.
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-55492
Relates-to: https://mattermost.atlassian.net/browse/MM-55488