Release v1.2.0 #250
Merged
Release v1.2.0 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
hanzei
requested review from
DHaussermann and
m1lt0n
and removed request for
mickmister
m1lt0n
approved these changes
Mar 23, 2023
Closed
mickmister
approved these changes
Mar 23, 2023
| "settings": [ | ||
| { | ||
| "key": "AdminUserIDs", | ||
| "display_name": "Admin User IDs:", | ||
| "type": "text", | ||
| "help_text": "List of users authorized to administer the plugin in addition to the System Admins. Must be a comma-separated list of user IDs.\n \n User IDs can be found in **System Console > User Management > Users**. Select the user's name, and the ID is displayed in the top-right corner of the banner." | ||
| "help_text": "List of users authorized to administer the plugin in addition to the System Admins. Must be a comma-separated list of user IDs.\n \n User IDs can be found in **System Console \u003e User Management \u003e Users**. Select the user's name, and the ID is displayed in the top-right corner of the banner.", |
There was a problem hiding this comment.
I wonder why those right carets were changed
Suggested change
| "help_text": "List of users authorized to administer the plugin in addition to the System Admins. Must be a comma-separated list of user IDs.\n \n User IDs can be found in **System Console \u003e User Management \u003e Users**. Select the user's name, and the ID is displayed in the top-right corner of the banner.", | |
| "help_text": "List of users authorized to administer the plugin in addition to the System Admins. Must be a comma-separated list of user IDs.\n \n User IDs can be found in **System Console > User Management > Users**. Select the user's name, and the ID is displayed in the top-right corner of the banner.", |
DHaussermann
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Tested and passed
- Install and setup
- Connect and disconnect (Tested browser and Desktop)
- New event DM from Bot
- Can set acceptance status
- Cal View is functional
- Status change prompt is working
- User counts are logged when status sync finishes
- Plugin start with enterprise license
- As a precaution, tested binary on Cloud servers and running in HA
- Version correctly set at v1.2.0
LGTM!
DHaussermann
added
4: Reviews Complete
|
@hanzei or @mickmister - Whenever possible can we get this merged and have a release cut so this can move forward to the marketplace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notable changes: