Use timezone when displaying event details #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
added
2: Dev Review
larkox
approved these changes
May 13, 2020
levb
approved these changes
May 13, 2020
DHaussermann
approved these changes
May 19, 2020
There was a problem hiding this comment.
Tested and passed
- Confirm Time on invite notification is adjusted to he users' timezone
- Tested multiple users in different timezones
- Confirmed information on invites remains accurate when updating timezone on MS Outlook side
LGTM! Thanks @mickmister for this fix.
mickmister
added
the
4: Reviews Complete
|
/update-branch |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 24.67% 24.63% -0.04%
==========================================
Files 65 65
Lines 2545 2549 +4
==========================================
Hits 628 628
- Misses 1841 1844 +3
- Partials 76 77 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The event invitation details logic was not using the user's timezone when displaying the event times
Ticket Link
Fixes #128